Skip to content

[Canvas] Add Lens Embeddables#56557

Closed
cqliu1 wants to merge 1 commit intoelastic:masterfrom
cqliu1:feat/lens-embeds-in-canvas
Closed

[Canvas] Add Lens Embeddables#56557
cqliu1 wants to merge 1 commit intoelastic:masterfrom
cqliu1:feat/lens-embeds-in-canvas

Conversation

@cqliu1
Copy link
Copy Markdown
Contributor

@cqliu1 cqliu1 commented Jan 31, 2020

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Build Failed


Test Failures

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/legacy/plugins/canvas/canvas_plugin_src/renderers/embeddable.input to expression Lens Embeddable converts to a savedLens expression

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(received).toBe(expected) // Object.is equality

Expected: "bar"
Received: "foo"
    at Object.it (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/legacy/plugins/canvas/canvas_plugin_src/renderers/embeddable/embeddable_input_to_expression.test.ts:78:21)
    at Object.asyncJestTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at resolve (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
    at new Promise (<anonymous>)
    at mapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at promise.then (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:73:41)
    at process._tickCallback (internal/process/next_tick.js:68:7)

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 changed the title [Canvas] Add Support for Lens Embeddables [Canvas] Add Lens Embeddables Feb 3, 2020
@streamich streamich added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// label Feb 7, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@cqliu1
Copy link
Copy Markdown
Contributor Author

cqliu1 commented Feb 12, 2020

Closing in favor of PR #57499.

@cqliu1 cqliu1 closed this Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants