[Console] Fix use of legacy config

[jloleysens]

Summary

Fix #56450

Tested locally and 'none' is being passed through to elasticsearch_proxy_confg.

Setup to reproduce on master

• Set elasticsearch.hosts: ['https://localhost:9200'] and elasticsearch.ssl.verificationMode: 'none' in your kibana.dev.yml
• yarn es snapshot --ssl
• yarn start --ssl

[elasticmachine]

Pinging @elastic/es-ui (Team:Elasticsearch UI)

[sebelga]

Code LGTM. Although I could not test locally as I couldn't reproduce the issue. If you want me to test it locally, can you provide the steps?

[jloleysens]

Thanks for the review @sebelga !

From the original issue:

elasticsearch.ssl.verificationMode: 'none' configured in mykibana.dev.yml

I'll add the steps in the description in future!

[jportner]

@jloleysens I ran into this problem and spent some time trying to track down what was happening.
I'm glad to see there's already a PR to fix it.

I noticed the bug was introduced in #55690.
Can I suggest taking a look at elasticsearch_proxy_config.ts as well?
The arguments in the createAgent and getElasticsearchProxyConfig functions do not have the correct type definitions, those should be changed so the type checker will catch problems like this.

[jloleysens]

@jportner Good point, regarding the typings downstream.

[jloleysens]

Unfortunately the upstream object still comes from an any so the type guards won't help in all cases, will add them though!

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: ad7bff8

History

• 💛 Build #23680 was flaky be4f68c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[cjcenizal]

@jloleysens I tried to first reproduce the reported problem but I wasn't able to:

1. I set elasticsearch.ssl.verificationMode: 'none' in my kibana.dev.yml.
2. I refreshed Kibana and navigated to Dev Tools.
3. I created an index, a document, and searched it all with no problem (requests below).

What am I doing wrong?

PUT test6

PUT test6/_doc/1
{
  "foo": "a"
}

GET test6/_search

[jloleysens]

@cjcenizal assuming you are testing before the fix :), you can add a log statement in logging the value of

kibana/src/plugins/console/server/lib/elasticsearch_proxy_config.ts

Line 33 in ad7bff8

const verificationMode = legacyConfig.ssl && legacyConfig.ssl.verificationMode;

to see the value of the config coming through. If it’s master it should have ssl but verificationMode is undefined.

[UPDATE]: I have updated the PR description

[jloleysens]

That should be throwing the error in the default case per request.

[cjcenizal]

Thanks @jloleysens! Code LGTM, tested locally and verified the verificationMode is being passed through as expected.