[Bugfix][State Management] 'state:storeInSessionStorage' doesn’t take effect for dashboard without full page reload

[Dosant]

Summary

This fixes a regression noticed by @majagrubic when working on #55443.
The regression caused by: #55158

The bug

'state:storeInSessionStorage' doesn’t take effect for dashboard without full page reload

To reproduce

1. Go to dashboard, see the unhashed state in the url
2. Via chrome's nav navigate to Management. Change 'state:storeInSessionStorage' setting.
3. Navigate back to dashboard using chrome's nav. - The state hashing option didn't take effect.
   It starts working after page reload.

The fix

kbnUrlStateStorage is responsible for updating the state in the url. The problem is, that it was initialised with uiSettings('state:storeInSessionStorage') only once! Together with angular modules initialisation. -

kibana/src/legacy/core_plugins/kibana/public/dashboard/np_ready/application.ts

Line 73 in d010abc

if (!angularModuleInstance) {

I had to move the initialisation inside angular so each time angular app gets mounted, it creates new instance with proper value from uiSettings.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• This was checked for cross-browser compatibility, including a check against IE11
• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: e663e83

History

• 💚 Build #23280 succeeded d010abc
• 💔 Build #23269 failed 35db869

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[majagrubic]

Looks good!

[flash1293]

Code LGTM, didn't test

[flash1293]

nit: It's not a big deal, but as we are trying to get away from angular we could already do that step here and call createKbnUrlStorage directly within the controller instead of letting angular handle this. Not blocking this merge, we can also tackle that later.

[Dosant]

I needed to make sure that Listing page and Dashboard page are using the same instance of kbnUrlStateStorage.

When we clean up angular from here, these 2 just should move back somewhere to the root of the plugin and then passed down to react components.

[flash1293]

Why is this required? I'm asking because the dashboard listing page and the actual dashboard page are two separate apps - if you are switching between the two it is unmounting and re-mounting the application anyway (new angular context and so on). https://github.com/elastic/kibana/blob/master/src/legacy/core_plugins/kibana/public/dashboard/plugin.ts#L128

That was necessary because of the different urls - the listing page is the dashboards app, the individual dashboard is the dashboard app.