Skip to content

Conversation

@kertal
Copy link
Member

@kertal kertal commented Jan 28, 2020

Summary

Due to a recent change in ElasticSearch the functional tests of Discover's Context view using date_nanos with custom timestamp format are failing

Manually Reproduce it:

Use latest snapshot

KBN_ES_SNAPSHOT_USE_UNVERIFIED='1' yarn es snapshot

Install testdata:

node scripts/es_archiver.js load date_nanos_mixed --verbose --es-url http://elastic:changeme@localhost:9200 --kibana-url http://elastic:changeme@localhost:5601/{basePath}/

it uses the following mapping of the timestamp:

"timestamp": {
          "format": "yyyy-MM-dd HH:mm:ss.SSSSSS",
          "type": "date_nanos"
}

Use this link to get to the error message:

http://localhost:5601/{basePath}/app/kibana#/discover/context/date_nanos_custom_timestamp/2?_a=(columns:!(_source),filters:!(),predecessorCount:5,sort:!(timestamp,desc),successorCount:5)&_g=(refreshInterval:(pause:!t,value:0),time:(from:now-15y,to:now))

Reproduce the error via console

POST /date_nanos_custom_timestamp/_search
{
  "size": 5,
  "search_after": [
    "1571646604828733000",
    1
  ],
  "sort": [
    {
      "timestamp": {
        "order": "desc",
        "unmapped_type": "boolean"
      }
    },
    {
      "_doc": {
        "order": "desc",
        "unmapped_type": "boolean"
      }
    }
  ]
  }
}

Works when providing the search_after value a number (However we need to provide it as text, because the browsers can't handle BigInt)

POST /date_nanos_custom_timestamp/_search
{
  "size": 5,
  "search_after": [
    1571646604828733000,
    1
  ],
  "sort": [
    {
      "timestamp": {
        "order": "desc",
        "unmapped_type": "boolean"
      }
    },
    {
      "_doc": {
        "order": "desc",
        "unmapped_type": "boolean"
      }
    }
  ]
  }
}

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@kertal kertal self-assigned this Jan 28, 2020
@kertal kertal added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Jan 28, 2020
@kertal kertal requested a review from tylersmalley January 28, 2020 17:10
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley merged commit b9d18c4 into elastic:master Jan 28, 2020
@rashmivkulkarni
Copy link
Contributor

hello @kertal ,
I see the test being skipped with a comment. Is there a fix coming up for it ?

@kertal
Copy link
Member Author

kertal commented Feb 17, 2020

Hi, thanks for reminding 👍 , I've to write a ticket in the Elasticsearch repo, and add an issue in Kibana, to enable the test when the invalid request works in ES (It did for a while)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants