Skip to content

[ML] Anomaly Detection: Fix persist/restore of refreshInterval in globalState. #56113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
walterra merged 3 commits into from
Jan 28, 2020
Merged

[ML] Anomaly Detection: Fix persist/restore of refreshInterval in globalState. #56113

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8875b64
[ML] Fix persist/restore of refreshInterval in globalState.
walterra Jan 28, 2020
e3d76bf
[ML] Fix jest tests.
walterra Jan 28, 2020
b724e4f
[ML] Fix useEffect refreshInterval comparator.
walterra Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions x-pack/legacy/plugins/ml/public/application/components/navigation_menu/top_nav/top_nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
mlTimefilterTimeChange$,
} from '../../../services/timefilter_refresh_service';
import { useUiContext } from '../../../contexts/ui/use_ui_context';
import { useUrlState } from '../../../util/url_state';

interface Duration {
start: string;
Expand All @@ -40,9 +41,17 @@ function updateLastRefresh(timeRange: OnRefreshProps) {

export const TopNav: FC = () => {
const { chrome, timefilter, timeHistory } = useUiContext();
const [globalState, setGlobalState] = useUrlState('_g');
const getRecentlyUsedRanges = getRecentlyUsedRangesFactory(timeHistory);

const [refreshInterval, setRefreshInterval] = useState(timefilter.getRefreshInterval());
const [refreshInterval, setRefreshInterval] = useState(
globalState?.refreshInterval ?? timefilter.getRefreshInterval()
);
useEffect(() => {
setGlobalState({ refreshInterval });
timefilter.setRefreshInterval(refreshInterval);
}, [refreshInterval.pause, refreshInterval.value]);

const [time, setTime] = useState(timefilter.getTime());
const [recentlyUsedRanges, setRecentlyUsedRanges] = useState(getRecentlyUsedRanges());
const [isAutoRefreshSelectorEnabled, setIsAutoRefreshSelectorEnabled] = useState(
Expand Down Expand Up @@ -96,20 +105,13 @@ export const TopNav: FC = () => {
}

function updateInterval({
isPaused,
refreshInterval: interval,
isPaused: pause,
refreshInterval: value,
}: {
isPaused: boolean;
refreshInterval: number;
}) {
const newInterval = {
pause: isPaused,
value: interval,
};
// Update timefilter for controllers listening for changes
timefilter.setRefreshInterval(newInterval);
// Update state
setRefreshInterval(newInterval);
setRefreshInterval({ pause, value });
}

return (
Expand Down