Skip to content

[Index Management] add try/catch when parsing index filter from URI #56051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alisonelizabeth merged 1 commit into from
Jan 28, 2020
Merged

[Index Management] add try/catch when parsing index filter from URI #56051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions ...y/plugins/index_management/public/app/sections/home/index_list/index_table/index_table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,13 @@ export class IndexTable extends Component {
const { filterChanged, filterFromURI } = this.props;
if (filterFromURI) {
const decodedFilter = decodeURIComponent(filterFromURI);
filterChanged(EuiSearchBar.Query.parse(decodedFilter));

try {
const filter = EuiSearchBar.Query.parse(decodedFilter);
filterChanged(filter);
} catch (e) {
this.setState({ filterError: e });
}
}
}
componentWillUnmount() {
Expand All @@ -122,7 +128,8 @@ export class IndexTable extends Component {
return;
}
return (
<Fragment>
<>
<EuiSpacer />
<EuiCallOut
iconType="faceSad"
color="danger"
Expand All @@ -134,8 +141,8 @@ export class IndexTable extends Component {
},
})}
/>
<EuiSpacer size="l" />
</Fragment>
<EuiSpacer />
</>
);
}
onFilterChanged = ({ query, error }) => {
Expand Down