Skip to content

Conversation

@simianhacker
Copy link
Member

Summary

This PR fixes some layout issues with the Metrics Explorer that prevented the chart titles from truncating properly.

Before

image

After

image

@simianhacker simianhacker added bug Fixes for quality problems that affect the customer experience release_note:fix Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.6.0 labels Jan 24, 2020
@simianhacker simianhacker requested a review from phillipb January 24, 2020 21:37
@simianhacker simianhacker requested review from a team as code owners January 24, 2020 21:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hbharding hbharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@simianhacker
Copy link
Member Author

@elasticmachine merge upstream

@simianhacker
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker merged commit 76628cd into elastic:master Jan 28, 2020
simianhacker added a commit to simianhacker/kibana that referenced this pull request Jan 28, 2020
simianhacker added a commit to simianhacker/kibana that referenced this pull request Jan 28, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 29, 2020
* master: (31 commits)
  [SIEM] Overview page feedback (elastic#56261)
  refactor (elastic#56131)
  [NP Cleanup] Remove ui/public/inspector (elastic#55677)
  [SIEM] [TIMELINE] Only add endpoint logo when on event.module === endgame (elastic#56263)
  Basic Functionality Alert List (elastic#55800)
  [SIEM] Fix filters on Hosts and Network page (elastic#56234)
  [SIEM] Adds ability to infer the newsfeed.enabled setting (elastic#56236)
  [SIEM][Detection Engine] critical blocker for updated rules
  [SIEM][Detection Engine] critical blocker, fixes ordering issue that causes rules to not run the first time
  [SIEM] Add link to endpoint app through reference.url (elastic#56211)
  [Metrics UI] Fixing title truncation in Metrics Explorer (elastic#55917)
  [SIEM] Put the notice for rules in comment block (elastic#56123)
  [SIEM][Detection Engine] critical blocker with the UI crashing
  Consistent timeouts for the Space onPostAuth interceptor tests (elastic#56158)
  Skip tests that depend on other skipped test
  [SIEM] [Detection Engine] Timestamps for rules (elastic#56197)
  Sort server-side in SavedObject export (elastic#55128)
  [Reporting] Document the 8.0 breaking changes (elastic#56187)
  Revert "[Monitoring] Change all configs to `monitoring.*`" (elastic#56214)
  add owners for es_archiver (elastic#56184)
  ...
simianhacker added a commit that referenced this pull request Jan 29, 2020
simianhacker added a commit that referenced this pull request Jan 29, 2020
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 29, 2020
…55831

* '7.x' of github.com:elastic/kibana: (78 commits)
  Re-enable watcher FireFox functional test (elastic#56112) (elastic#56294)
  [Metrics UI] Fixing title truncation in Metrics Explorer (elastic#55917) (elastic#56248)
  [APM] x-axis labels on Error occurrences chart are incorrect based on Kibana timezone (elastic#55686) (elastic#56288)
  Migrate saved_object_save_as_checkbox directive to timelion (elastic#56114) (elastic#56286)
  [APM] Treat error.exception.stacktrace.line as optional (elastic#55733) (elastic#55840)
  Remove alerts and actions from feature catalogue (elastic#56140) (elastic#56208)
  Migrate UI capabilities to use new platform APIs (elastic#56070) (elastic#56207)
  [ML] Add functional tests for analytics UI: creation addition and regression/outlier results (elastic#56059) (elastic#56191)
  [SIEM] Overview page feedback (elastic#56261) (elastic#56276)
  [NP Cleanup] Remove ui/public/inspector (elastic#55677) (elastic#56271)
  [Index template] Fix editor should support mappings types (elastic#55804)
  fixes map index message (elastic#56104) (elastic#56194)
  [SIEM] [TIMELINE] Only add endpoint logo when on event.module === endgame (elastic#56263) (elastic#56269)
  [SIEM] Fix filters on Hosts and Network page (elastic#56234) (elastic#56267)
  [SIEM] Adds ability to infer the newsfeed.enabled setting (elastic#56236) (elastic#56265)
  [SIEM][Detection Engine] critical blocker for updated rules (elastic#56259)
  [SIEM] Put the notice for rules in comment block (elastic#56123) (elastic#56246)
  [SIEM][Detection Engine] critical blocker, fixes ordering issue that causes rules to not run the first time (elastic#56256)
  [Reporting/NP] Migration of Reporting Security dependency (elastic#56046) (elastic#56198)
  [SIEM] Add link to endpoint app through reference.url (elastic#56211) (elastic#56250)
  ...

# Conflicts:
#	x-pack/plugins/watcher/public/plugin.ts
@simianhacker simianhacker deleted the fix-metrics-explorer-title-truncation-again branch April 17, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.6.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants