-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[SIEM] [Detection Engine] Log time gaps as failures for now #55515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lution until a feature is fully fleshed out to report this and future messaging / monitoring.
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
FrankHassanabad
approved these changes
Jan 22, 2020
Contributor
FrankHassanabad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ng with the status_date field.
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
dhurley14
added a commit
to dhurley14/kibana
that referenced
this pull request
Jan 22, 2020
…55515) * log a failure to failure history if time gap is detected. stop-gap solution until a feature is fully fleshed out to report this and future messaging / monitoring. * write date the gap warning occurred in the last_failure_at field, along with the status_date field.
dhurley14
added a commit
to dhurley14/kibana
that referenced
this pull request
Jan 22, 2020
…55515) * log a failure to failure history if time gap is detected. stop-gap solution until a feature is fully fleshed out to report this and future messaging / monitoring. * write date the gap warning occurred in the last_failure_at field, along with the status_date field.
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 22, 2020
…t-of-legacy * 'master' of github.com:elastic/kibana: Restore 200 OK + response payload for save and delete endpoints (elastic#55535) [SIEM] [Detection Engine] Log time gaps as failures for now (elastic#55515) [NP] KibanaRequest provides request abortion event (elastic#55061)
dhurley14
added a commit
that referenced
this pull request
Jan 22, 2020
…55539) * log a failure to failure history if time gap is detected. stop-gap solution until a feature is fully fleshed out to report this and future messaging / monitoring. * write date the gap warning occurred in the last_failure_at field, along with the status_date field.
dhurley14
added a commit
that referenced
this pull request
Jan 22, 2020
…55540) * log a failure to failure history if time gap is detected. stop-gap solution until a feature is fully fleshed out to report this and future messaging / monitoring. * write date the gap warning occurred in the last_failure_at field, along with the status_date field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Log a failure to failure history if time gap is detected. stop-gap solution until a feature is fully fleshed out to report this and future messaging / monitoring.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers