Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry - identify enterprise clusters #55355

Conversation

peterschretlen
Copy link
Contributor

Followup to #49474. Elasticsearch and Kibana have added support for the 'enterprise' license type ( The "enterprise" license type is currently supported and used by ECE and ECK, but this will soon extend to the stack as well )

For backwards compatibility reasons, a call to the Get license API in elasticsearch will return a platinum license when an enterprise license is installed. To get the true license in ( versions >= 7.6 and < 8.0 ) you can pass the accept_enterprise=true query parameter. In 8.0 this parameter will be deprecated , and the enterprise value will be returned.

This PR adds the accept_enterprise=true query parameter to the license stats collected by telemetry.

@peterschretlen peterschretlen added Feature:Telemetry v7.7.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jan 20, 2020
@peterschretlen peterschretlen self-assigned this Jan 20, 2020
@peterschretlen
Copy link
Contributor Author

Will require updated es snapshot in order to run API integration tests. Current snapshot does not have the accept_enterprise flag on the _license API.

@peterschretlen
Copy link
Contributor Author

@elasticmachine merge upstream

@peterschretlen
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Feb 6, 2020
@peterschretlen
Copy link
Contributor Author

Confirmed using a dev enterprise license that it is picked up as expected

image

@peterschretlen peterschretlen marked this pull request as ready for review February 7, 2020 17:06
@peterschretlen peterschretlen requested a review from Bamieh February 7, 2020 17:07
@peterschretlen
Copy link
Contributor Author

@Bamieh minor change so that telemetry recognizes enterprise licenses during 7.x

@Bamieh
Copy link
Member

Bamieh commented Feb 10, 2020

@elasticmachine merge upstream

Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@peterschretlen peterschretlen merged commit ce4a0f7 into elastic:master Feb 10, 2020
peterschretlen pushed a commit to peterschretlen/kibana that referenced this pull request Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants