Skip to content

[ML] Accessibility fix for structural markup on table rows #55075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2020
Merged

[ML] Accessibility fix for structural markup on table rows #55075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03805a2
[ML] Accessibility fix for structural markup on table rows
peteharverson Jan 16, 2020
08362a4
[ML] Fix type error on Transforms table cell for scope property
peteharverson Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ion/components/annotations/annotations_table/__snapshots__/annotations_table.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ...ugins/ml/public/application/components/annotations/annotations_table/annotations_table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@ const AnnotationsTable = injectI18n(
}),
sortable: true,
width: '50%',
scope: 'row',
},
{
field: 'timestamp',
Expand Down
1 change: 1 addition & 0 deletions ...egacy/plugins/ml/public/application/components/anomalies_table/anomalies_table_columns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ export function getColumns(
defaultMessage: 'time',
}),
dataType: 'date',
scope: 'row',
render: date => renderTime(date, interval),
textOnly: true,
sortable: true,
Expand Down
1 change: 1 addition & 0 deletions x-pack/legacy/plugins/ml/public/application/components/ml_in_memory_table/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export interface FieldDataColumnType<T> {
render?: RenderFunc;
footer?: string | ReactElement | FooterFunc;
textOnly?: boolean;
scope?: 'col' | 'row' | 'colgroup' | 'rowgroup';
Copy link
Contributor

@darnautov darnautov Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to import this type from eui?

Copy link
Contributor

@darnautov darnautov Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so, it is TableHeaderCellScope

Copy link
Contributor Author

@peteharverson peteharverson Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to copy those scope values locally for now. We plan to switch over to using the types which are now available in EUI, hopefully for 7.7.

'data-test-subj'?: string;
}

Expand Down
1 change: 1 addition & 0 deletions ...ion/data_frame_analytics/pages/analytics_management/components/analytics_list/columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ export const getColumns = (
sortable: true,
truncateText: true,
'data-test-subj': 'mlAnalyticsTableColumnId',
scope: 'row',
},
{
field: DataFrameAnalyticsListColumn.description,
Expand Down
1 change: 1 addition & 0 deletions ...blic/application/jobs/jobs_list/components/job_details/forecasts_table/forecasts_table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ class ForecastsTableUI extends Component {
render: date => formatDate(date, TIME_FORMAT),
textOnly: true,
sortable: true,
scope: 'row',
},
{
field: 'forecast_start_timestamp',
Expand Down
1 change: 1 addition & 0 deletions x-pack/legacy/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/jobs_list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ class JobsListUI extends Component {
sortable: true,
truncateText: false,
width: '20%',
scope: 'row',
render: isManagementTable ? id => this.getJobIdLink(id) : undefined,
},
{
Expand Down
2 changes: 2 additions & 0 deletions .../application/settings/calendars/edit/events_table/__snapshots__/events_table.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ...legacy/plugins/ml/public/application/settings/calendars/edit/events_table/events_table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ export const EventsTable = injectI18n(function EventsTable({
}),
sortable: true,
truncateText: true,
scope: 'row',
},
{
field: 'start_time',
Expand Down
1 change: 1 addition & 0 deletions ...gins/ml/public/application/settings/calendars/list/table/__snapshots__/table.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions x-pack/legacy/plugins/ml/public/application/settings/calendars/list/table/table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export const CalendarsListTable = injectI18n(function CalendarsListTable({
}),
sortable: true,
truncateText: true,
scope: 'row',
render: id => <EuiLink href={`#/settings/calendars_list/edit_calendar/${id}`}>{id}</EuiLink>,
},
{
Expand Down
2 changes: 2 additions & 0 deletions ...plugins/ml/public/application/settings/filter_lists/list/__snapshots__/table.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions x-pack/legacy/plugins/ml/public/application/settings/filter_lists/list/table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ function getColumns() {
}),
render: id => <EuiLink href={`#/settings/filter_lists/edit_filter_list/${id}`}>{id}</EuiLink>,
sortable: true,
scope: 'row',
},
{
field: 'description',
Expand Down
1 change: 1 addition & 0 deletions .../transform/public/app/sections/transform_management/components/transform_list/columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ export const getColumns = (
name: 'ID',
sortable: true,
truncateText: true,
scope: 'row',
},
{
field: TRANSFORM_LIST_COLUMN.DESCRIPTION,
Expand Down