moving expression utils into visualizations plugin#54999
Closed
ppisljar wants to merge 4 commits intoelastic:masterfrom
Closed
moving expression utils into visualizations plugin#54999ppisljar wants to merge 4 commits intoelastic:masterfrom
ppisljar wants to merge 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
ryankeairns
approved these changes
Jan 16, 2020
Contributor
ryankeairns
left a comment
There was a problem hiding this comment.
LGTM from design side. A single scss file was removed.
a40e06e to
2ef8230
Compare
Contributor
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
Contributor
Author
|
replaced by #56650 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers