Skip to content

[Maps] pre-populate custom color maps#54964

Closed
nreese wants to merge 0 commit intoelastic:masterfrom
nreese:pre_populate_custom_ramp
Closed

[Maps] pre-populate custom color maps#54964
nreese wants to merge 0 commit intoelastic:masterfrom
nreese:pre_populate_custom_ramp

Conversation

@nreese
Copy link
Contributor

@nreese nreese commented Jan 15, 2020

Fixes #54650

Its always easier to edit something then build something from scratch. So, this PR will generate the color map when users select "Custom color map" for the first time. This will make user's lives much easier. For ordinal styling, the user will see the valid ranges for the data set. For categorical data, the user will see the top 9 terms.

Screen Shot 2020-01-15 at 3 23 51 PM

Screen Shot 2020-01-15 at 3 24 03 PM

@nreese nreese added release_note:enhancement Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.7.0 labels Jan 15, 2020
@nreese nreese requested a review from a team as a code owner January 15, 2020 21:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jsanz
Copy link
Contributor

jsanz commented Jan 16, 2020

Testing it works as expected but only the first time, if you change for another field the custom ramp is still showing for the previous field.

This is not wrong by itself, the problem is that then I can't see a way to populate again the custom ramp and I can't remove all the values.

Peek 2020-01-16 12-30

Maybe it would make sense when changing the field to clean the custom ramp to get in the same state as if it was the first execution?

@nreese
Copy link
Contributor Author

nreese commented Jan 16, 2020

Maybe it would make sense when changing the field to clean the custom ramp to get in the same state as if it was the first execution?

I like that idea. For most cases, the fields are pretty dissimilar in values so clearing the customColorRamp makes sense when changing fields. What do you think @thomasneirynck?

@nreese nreese closed this Jan 22, 2020
@nreese nreese force-pushed the pre_populate_custom_ramp branch from 45b855f to c6f9eff Compare January 22, 2020 12:56
@nreese
Copy link
Contributor Author

nreese commented Jan 22, 2020

Branch and PR got messed up, replacing with #55545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:enhancement Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maps] pre-populate custom color maps

4 participants

Comments