[Maps] Categorical palettes#54918
Merged
elizabetdev merged 2 commits intoelastic:masterfrom Jan 15, 2020
Merged
Conversation
nreese
added
release_note:fix
v7.7.0
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
Contributor
|
@miukimiu I removed the I also added |
Contributor
Author
|
Thanks @nreese! |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
user doesn't have permission to update head repository |
Contributor
|
@elasticmachine merge upstream |
Contributor
|
user doesn't have permission to update head repository |
Contributor
Author
|
jenkins test this |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Jan 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On #54408 it was introduced 3 categorical color palettes: euiPaletteColorBlind() and two ColorBrewer palettes.
Both ColorBrewer palettes aren't fully color blind safe and have some contrast issues in dark/light modes.
For this reason and until we include more qualitative palettes into EUI, we decided to remove the ColorBrewer palettes.