[Mappings editor] Improve data type descriptions.#54844
Merged
cjcenizal merged 3 commits intoelastic:feature/mappings-editorfrom Jan 14, 2020
Merged
Conversation
cjcenizal
added
Team:Kibana Management
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Contributor
|
Remove "for search suggestions" in the Search-as-you type description. I don't feel that its needed because you added the ending clause. What does "their" refer to in the Token count fields description? Strings? |
gchaps
approved these changes
Jan 14, 2020
cjcenizal
changed the title
Contributor
Author
|
Merging now, will address CI problems in the main branch. |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies feedback from #54817