[Maps] Add mapbox-gl-rtl-text library for RTL languages #54842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for RTL languages (Arabic and Hebrew) in the basemaps. Without this library the RTL languages appear backwards.
nickpeihl
added
release_note:fix
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
kindsun
approved these changes
Jan 15, 2020
Contributor
kindsun
left a comment
kindsun
left a comment
There was a problem hiding this comment.
lgtm! Is the latest lib version and works as expected. Hebrew and Arabic names appear correctly.
- code review
- tested locally in chrome
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
nickpeihl
added a commit
to nickpeihl/kibana
that referenced
this pull request
Jan 15, 2020
This adds support for RTL languages (Arabic and Hebrew) in the basemaps. Without this library the RTL languages appear backwards.
nickpeihl
added a commit
that referenced
this pull request
Jan 15, 2020
This adds support for RTL languages (Arabic and Hebrew) in the basemaps. Without this library the RTL languages appear backwards. Co-authored-by: Elastic Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 15, 2020
* upstream/master: (72 commits) [ML] Calculate model memory limit API integration tests (elastic#54557) Skip flakey index template component integration tests. (elastic#54878) Add label and icon to nested fields in the doc table (elastic#54199) Reverse dependency of home plugin and apm/ml/cloud (elastic#52883) [SIEM][Detection Engine] Order JSON keys, fix scripts, update pre-packaged rules update invalid snapshot add readme note about alerting / manage_api_key cluster privilege (elastic#54639) [SIEM] New Overview Page (elastic#54783) [Uptime] Feature/refactor context initialization (elastic#54494) Upgrade EUI to v18.2.0 (elastic#54786) [SIEM] [Detection engine] from signals to timeline (elastic#54769) [Index Management] Add Mappings Editor to Index Template Wizard (elastic#47562) [SIEM][Detection Engine] Removes deprecated filter from mapping [Maps] Add categorical styling (elastic#54408) Add mapbox-gl-rtl-text library (elastic#54842) [SIEM][Detection Engine] Adds actions to Rule Details (elastic#54828) Lexicographically sort location tags (elastic#54832) [Maps] expand extent filter to tile boundaries (elastic#54276) [Maps] Use v7.6 Elastic Maps Service API (elastic#54399) [DOCS] Adds monitoring setting (elastic#54819) ...
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
This adds support for RTL languages (Arabic and Hebrew) in the basemaps. Without this library the RTL languages appear backwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54813
The mapbox-gl-rtl-text library adds support for right-to-left languages (Arabic and Hebrew) in the basemaps. Without this library the labels for Arabic and Hebrew languages appear backwards.
Note the respective Arabic and Hebrew labels for Cairo and Tel Aviv in the screenshots below.
Before:
After:
