[SIEM] [Detection engine] add status to rule details#54812
Merged
XavierM merged 2 commits intoelastic:masterfrom Jan 14, 2020
Merged
[SIEM] [Detection engine] add status to rule details#54812XavierM merged 2 commits intoelastic:masterfrom
XavierM merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
dhurley14
reviewed
Jan 14, 2020
| export const DETECTION_ENGINE_PRIVILEGES_URL = `${DETECTION_ENGINE_URL}/privileges`; | ||
| export const DETECTION_ENGINE_INDEX_URL = `${DETECTION_ENGINE_URL}/index`; | ||
| export const DETECTION_ENGINE_TAGS_URL = `${DETECTION_ENGINE_URL}/tags`; | ||
| export const DETECTION_ENGINE_RULES_STATUS = `${DETECTION_ENGINE_URL}/rules/_find_statuses`; |
Contributor
There was a problem hiding this comment.
Can this be updated to utilize
so the new const would just be ${DETECTION_ENGINE_RULES_URL}/_find_statuses?
dhurley14
reviewed
Jan 14, 2020
| t.partial({ | ||
| last_failure_at: t.string, | ||
| last_failure_message: t.string, | ||
| output_index: t.string, |
Contributor
There was a problem hiding this comment.
Should last_success_at and last_success_message be included in this? Does not have to be, but just wondering.
dhurley14
approved these changes
Jan 14, 2020
Contributor
dhurley14
left a comment
dhurley14
left a comment
There was a problem hiding this comment.
Two questions but other than those LGTM! Thanks for getting this out so swiftly.
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
FrankHassanabad
approved these changes
Jan 14, 2020
Contributor
FrankHassanabad
left a comment
FrankHassanabad
left a comment
There was a problem hiding this comment.
Looked at the code, tested the code, and everything looks great here.
LGTM
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Jan 14, 2020
XavierM
added a commit
that referenced
this pull request
Jan 15, 2020
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Status to rule details
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers