Skip to content

[Mappings editor] Add _routing advanced configuration#54725

Merged
alisonelizabeth merged 5 commits intoelastic:feature/mappings-editorfrom
sebelga:mappings-editor/_routing-configuration
Jan 14, 2020
Merged

[Mappings editor] Add _routing advanced configuration#54725
alisonelizabeth merged 5 commits intoelastic:feature/mappings-editorfrom
sebelga:mappings-editor/_routing-configuration

Conversation

@sebelga
Copy link
Contributor

@sebelga sebelga commented Jan 14, 2020

This PR adds the missing _routing advanced configuration to the mappings editor

Fix #54624

Screen Shot 2020-01-14 at 19 19 06

@sebelga sebelga added Feature:Mappings Editor Index mappings editor UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// labels Jan 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this!

I pushed one commit with the following changes:

  • I removed the help text and instead made the switch label more verbose.

Screen Shot 2020-01-14 at 9 45 33 AM

  • I added the following to the Joi schema to fix a bug where adding _routing or _meta data via the load JSON modal wasn't working.
  _meta: Joi.object(),
  _routing: Joi.object().keys({
    required: Joi.boolean().strict(),
  }),

@sebelga
Copy link
Contributor Author

sebelga commented Jan 14, 2020

Awesome, thanks for the review @alisonelizabeth !

@kibanamachine
Copy link
Contributor

💔 Build Failed

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor

Going to merge this since all tests have passed.

@alisonelizabeth alisonelizabeth merged commit 1888775 into elastic:feature/mappings-editor Jan 14, 2020
@sebelga sebelga deleted the mappings-editor/_routing-configuration branch January 15, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Mappings Editor Index mappings editor UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants