[Mappings editor] Add _routing advanced configuration#54725
Merged
alisonelizabeth merged 5 commits intoelastic:feature/mappings-editorfrom Jan 14, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
alisonelizabeth
approved these changes
Jan 14, 2020
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
LGTM. Thanks for adding this!
I pushed one commit with the following changes:
- I removed the help text and instead made the switch label more verbose.
- I added the following to the
Joischema to fix a bug where adding_routingor_metadata via the load JSON modal wasn't working.
_meta: Joi.object(),
_routing: Joi.object().keys({
required: Joi.boolean().strict(),
}),
Contributor
Author
|
Awesome, thanks for the review @alisonelizabeth ! |
Contributor
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
Contributor
|
@elasticmachine merge upstream |
Contributor
|
Going to merge this since all tests have passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds the missing
_routingadvanced configuration to the mappings editorFix #54624