Skip to content

[Logs UI] Disable ML job setup form while setup is pending#54705

Merged
weltenwort merged 1 commit intoelastic:masterfrom
weltenwort:logs-ui-ml-integration-disable-setup-form-when-pending
Jan 14, 2020
Merged

[Logs UI] Disable ML job setup form while setup is pending#54705
weltenwort merged 1 commit intoelastic:masterfrom
weltenwort:logs-ui-ml-integration-disable-setup-form-when-pending

Conversation

@weltenwort
Copy link
Copy Markdown
Member

Summary

This PR disables the configuration for in the log rate and categories setup screens while the setup process is ongoing.

closes #54555

Previews

grafik

Checklist

@weltenwort weltenwort added release_note:enhancement v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.6.0 labels Jan 14, 2020
@weltenwort weltenwort self-assigned this Jan 14, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@weltenwort weltenwort marked this pull request as ready for review January 14, 2020 13:25
@weltenwort weltenwort requested a review from a team as a code owner January 14, 2020 13:25
setValidatedIndices,
validationErrors = [],
}: InitialConfigurationStepProps) => {
const disabled = useMemo(() => !editableFormStatus.includes(setupStatus), [setupStatus]);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's changing this setupStatus value and where?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's being passed in as a property to the component. It originates from the job management hook that uses a combination of the ML API responses and the setup flow state to determine the overall setup state.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok so this value was already being set, gotcha. Looks good then!

@weltenwort weltenwort merged commit 8d00dc6 into elastic:master Jan 14, 2020
@weltenwort weltenwort deleted the logs-ui-ml-integration-disable-setup-form-when-pending branch January 14, 2020 19:16
weltenwort added a commit to weltenwort/kibana that referenced this pull request Jan 14, 2020
…4705)

This disables the configuration for in the log rate and categories setup screens while the setup process is ongoing.
weltenwort added a commit that referenced this pull request Jan 14, 2020
Backports the following commits to 7.x:
 - [Logs UI] Disable ML job setup form while setup is pending (#54705)
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
…4705)

This disables the configuration for in the log rate and categories setup screens while the setup process is ongoing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Logs UI Logs UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.6.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Logs UI] Disable configuration form while setup is in progress

4 participants