[kbn/ui-shared-deps] include polyfills, required by some deps#54667
Merged
spalger merged 6 commits intoelastic:masterfrom Jan 14, 2020
Merged
[kbn/ui-shared-deps] include polyfills, required by some deps#54667spalger merged 6 commits intoelastic:masterfrom
spalger merged 6 commits intoelastic:masterfrom
Conversation
Member
|
@elasticmachine merge upstream |
Member
|
Looks like |
…er/kibana into implement/polyfills-in-shared-deps
tylersmalley
approved these changes
Jan 14, 2020
Member
tylersmalley
left a comment
tylersmalley
left a comment
There was a problem hiding this comment.
LGTM - confirmed this is the last issue to resolve for IE11
spalger
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
tylersmalley
approved these changes
Jan 14, 2020
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jan 14, 2020
…c#54667) * [kbn/ui-shared-deps] include polyfills, required by some deps * remove unnecessary dep * replace abort-controller for server side use Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
Author
|
7.x/7.6: 4e52072 |
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
…c#54667) * [kbn/ui-shared-deps] include polyfills, required by some deps * remove unnecessary dep * replace abort-controller for server side use Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of our shared deps rely on the polyfills to work in IE, and the polyfills count as implicit universal deps, so move them to our shared deps package.
Fixes #53904