[SIEM] Histogram enhancement#54544
Merged
angorayc merged 35 commits intoelastic:masterfrom Jan 14, 2020
Merged
Conversation
…o histogram-enhacement
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
Contributor
Author
|
jenkins test this please |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
| > | ||
| ): variable is GetNetworkDnsQuery.Variables => { | ||
| return ( | ||
| variable.isHistogram !== undefined && |
Contributor
There was a problem hiding this comment.
would the addition of a dns type that enabled a simple variable.isDNS be useful here?
Contributor
Author
There was a problem hiding this comment.
I added a prop isDNSHistogram but haven't changed this part successfully, as couldn't make typescript happy... Will put that as todos in my next PR.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
andrew-goldstein
approved these changes
Jan 14, 2020
Contributor
andrew-goldstein
left a comment
andrew-goldstein
left a comment
There was a problem hiding this comment.
Thanks @angorayc , this is exactly what we needed for the Overview! 🙏
Works great locally
LGTM 🚀
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Jan 14, 2020
* generic histogram container * generic histogram container * rename params * fix inspect * fix update with timerange * clean up props * send stackByField to server side * fix inspect button * helper node xavier * fix DNS histogram * fix DNS query params * move utils for fetch data into containers * cleanup graphql template on client side * rename grqphql data * i18n * fix type * fix i18n * fix i18n * fix subtitle * fix subtitle * fix i18n * fix for reviews * fix types * remove unused test * fix integration Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
angorayc
added a commit
that referenced
this pull request
Jan 14, 2020
* generic histogram container * generic histogram container * rename params * fix inspect * fix update with timerange * clean up props * send stackByField to server side * fix inspect button * helper node xavier * fix DNS histogram * fix DNS query params * move utils for fetch data into containers * cleanup graphql template on client side * rename grqphql data * i18n * fix type * fix i18n * fix i18n * fix subtitle * fix subtitle * fix i18n * fix for reviews * fix types * remove unused test * fix integration Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
* generic histogram container * generic histogram container * rename params * fix inspect * fix update with timerange * clean up props * send stackByField to server side * fix inspect button * helper node xavier * fix DNS histogram * fix DNS query params * move utils for fetch data into containers * cleanup graphql template on client side * rename grqphql data * i18n * fix type * fix i18n * fix i18n * fix subtitle * fix subtitle * fix i18n * fix for reviews * fix types * remove unused test * fix integration Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is part of https://github.com/elastic/siem-team/issues/484
Support legend Position: MatrixHistogram now takes
legendPosition, we can applyPositionenum from @elastic/charts to change it.Support
stackByOptionsfor dropdown list, example options:Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately