[Mappings editor] Clarify the loading JSON will overwrite existing mappings#54532
Merged
cjcenizal merged 4 commits intoelastic:feature/mappings-editorfrom Jan 14, 2020
Merged
Conversation
cjcenizal
added
Team:Kibana Management
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
alisonelizabeth
approved these changes
Jan 11, 2020
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
LGTM. Did not test locally. Thanks for making these changes!
(I think the issue linked in the comment is wrong, I believe it should be #54249.)
Contributor
Author
|
@elasticmachine merge upstream |
…u have to drop invalid options to proceed.
cjcenizal
force-pushed
the
mappings-editor/load-json-help
branch
from
85bcf6a to
54ab295
Compare
Contributor
Author
|
Updated copy per review from @gchaps.
|
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54249
I also tried to make the language around invalid options and dropping them more consistent, so that we could make the confirmation button text sound more like an explicit action.
@gchaps Could you take a look at the copy, please?