[Optimizer] Fix a stack overflow with watch_cache when it attempts to delete very large folders.

[chrisdavies]

This happens occasionally when the .cache/ui_bundles has a lot of files. The reason is that globby spreads all of the file paths as arguments to a function call: sindresorhus/globby#141

This is a quick workaround for the offending call site.

You can reproduce the bug by running node and then running a script like this (after replacing the placeholders):

const fs = require('fs');

for (let i = 1; i < 80000; ++i) {
  fs.writeFileSync(
    `PREFIX/kibana/data/built_assets/.cache/ui_bundles/BUNDLE_PATH/babel/test_${i}.json`,
    '{}'
  );
}

• Replace PREFIX/ with whatever is appropriate for your system
• Replace BUNDLE_PATH with whatever the existing path is on your system
• Change the yarn.lock file in some way yarn add ramda or something
• Run node scripts/functional_tests_server to see the error.

[chrisdavies]

retest

[chrisdavies]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: cb4a64f

History

• 💔 Build #19342 failed 32988ee
• 💔 Build #19333 failed 2c02e9e
• 💔 Build #19306 failed 2c02e9e
• 💔 Build #19286 failed 7a6b5f3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[tylersmalley]

LGTM - thanks the fix!

[mistic]

7.x: 63d0b60