[Monitoring] Migrate license expiration alert to Kibana alerting#54306
Merged
chrisronline merged 41 commits intoelastic:masterfrom Feb 3, 2020
Merged
[Monitoring] Migrate license expiration alert to Kibana alerting#54306chrisronline merged 41 commits intoelastic:masterfrom
chrisronline merged 41 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
7eacd14 to
9e5a7bc
Compare
…th test failures and typescript
igoristic
approved these changes
Jan 30, 2020
Contributor
igoristic
left a comment
There was a problem hiding this comment.
Looks good! Really excited about this feature 😃
Contributor
Author
|
@elasticmachine merge upstream |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Feb 3, 2020
…stic#54306) * License expiration * Flip off * Only require alerting and actions if enabled * Support date formating and timezones in the alert UI messages, support ccs better * Fix status tests * Fix up front end tests * Fix linting, and switch this back * Add this back in so legacy alerts continue to work * Fix type issues * Handle CCS better * Code cleanup * Fix type issues * Flip this off, and fix test * Moved the email address config to advanced settings, but need help with test failures and typescript * Fix issue with task manager * Deprecate email_address * Use any until we can figure out this TS issue * Fix type issue * More tests * Fix mocha tests * Use mock instead of any * I'm not sure why these changed... * Provide timezone in moment usage in tests for consistency * Fix type issue * Change how we get dateFormat and timezone * Change where we calculate the dates to show in the alerts UI * Show deprecation warning based on the feature toggle * Ensure we are using UTC * PR feedback * Only add this if the feature flag is enabled * Fix tests * Ensure we only attempt to look this up if the feature flag is enabled Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Member
|
Looks like there were changes required from the EUI bump in #56228 which were not here, so it failed once it hit master. I am pushing a fix. |
Member
|
@chrisronline, can you confirm 0440ae5 is expected? |
Contributor
Author
|
@tylersmalley Yup, looks expected |
chrisronline
added a commit
that referenced
this pull request
Feb 4, 2020
) (#56677) * License expiration * Flip off * Only require alerting and actions if enabled * Support date formating and timezones in the alert UI messages, support ccs better * Fix status tests * Fix up front end tests * Fix linting, and switch this back * Add this back in so legacy alerts continue to work * Fix type issues * Handle CCS better * Code cleanup * Fix type issues * Flip this off, and fix test * Moved the email address config to advanced settings, but need help with test failures and typescript * Fix issue with task manager * Deprecate email_address * Use any until we can figure out this TS issue * Fix type issue * More tests * Fix mocha tests * Use mock instead of any * I'm not sure why these changed... * Provide timezone in moment usage in tests for consistency * Fix type issue * Change how we get dateFormat and timezone * Change where we calculate the dates to show in the alerts UI * Show deprecation warning based on the feature toggle * Ensure we are using UTC * PR feedback * Only add this if the feature flag is enabled * Fix tests * Ensure we only attempt to look this up if the feature flag is enabled Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
Author
|
Backport: 7.x: 1601403 |
10 tasks
Contributor
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #42960
Replaces #49219
This is the first PR of a set of PRs aimed to migrate the six watcher-based cluster alerts to use the Kibana alerting framework.
This PR focuses on the license expiration alert, as well as laying out the foundation of how the rest of the alerts will be migrated.
There are three main things we need to do to accomplish this:
For the first one, the ES team will be introducing an api that will allow us to do that from the UI (pending ticket creation). For testing this PR, let's assume those are disabled properly and we don't need to worry about that now.
For the second one, we want to slowly merge all of this work into master (to avoid one large PR) so we are going to add a constant that will be set to
falseuntil all of the alerts are ready. Then, the final PR will remove this constant and all of the new alerts will be available to users.Finally, for the last one, we want to ensure the messaging is consistent (even though it might be somewhat poor) for this phase.
Screenshots
Testing
trueWe need to easily simulate the scenario in which this alert would fire. To do that, we'll leverage the monitoring ingest pipeline to set an expiration date in the near future. See these commands:
TODO
.monitoring-alerts-*should be removeddefault_admin_emaillogic since we aren't using that in the Kibana alerting world