Skip to content

Migrate Management views to Kibana Platform plugin #53880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 21, 2020
Merged

Migrate Management views to Kibana Platform plugin #53880

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e7fbde5
Move files
azasypkin Dec 27, 2019
74af29e
Changes including handling of review feedback from Larry and Caroline.
azasypkin Dec 31, 2019
0a2e2d2
Re-expose role/user management apps paths to tests.
azasypkin Jan 14, 2020
c352d13
Fix: remove expectation of global URL state in role mappings tests.
azasypkin Jan 15, 2020
093b223
Review#2: remove role related methods from `UsersAPIClient`, use more…
azasypkin Jan 15, 2020
e783bb2
Merge branch 'master' into issue-xxx-np-management
azasypkin Jan 17, 2020
e9cb504
Review#3: remove unnecessary ts-ignore directives and show a toast wh…
azasypkin Jan 17, 2020
28aff3b
Merge branch 'master' into issue-xxx-np-management
elasticmachine Jan 18, 2020
c4cba87
Merge branch 'master' into issue-xxx-np-management
elasticmachine Jan 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
7 changes: 6 additions & 1 deletion src/plugins/management/public/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,12 @@ export function plugin(initializerContext: PluginInitializerContext) {
return new ManagementPlugin();
}

export { ManagementSetup, ManagementStart, RegisterManagementApp } from './types';
export {
ManagementSetup,
ManagementStart,
RegisterManagementApp,
RegisterManagementAppArgs,
} from './types';
export { ManagementApp } from './management_app';
export { ManagementSection } from './management_section';
export { ManagementSidebarNav } from './components'; // for use in legacy management apps
28 changes: 0 additions & 28 deletions x-pack/legacy/plugins/security/common/model.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion x-pack/legacy/plugins/security/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/

import { Legacy } from 'kibana';
import { AuthenticatedUser } from './common/model';
import { AuthenticatedUser } from '../../../plugins/security/public';

/**
* Public interface of the security plugin.
Expand Down
3 changes: 0 additions & 3 deletions x-pack/legacy/plugins/security/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ export const security = kibana =>
},

uiExports: {
chromeNavControls: [],
managementSections: ['plugins/security/views/management'],
styleSheetPaths: resolve(__dirname, 'public/index.scss'),
apps: [
{
Expand Down Expand Up @@ -76,7 +74,6 @@ export const security = kibana =>
'plugins/security/hacks/on_unauthorized_response',
'plugins/security/hacks/register_account_management_app',
],
home: ['plugins/security/register_feature'],
injectDefaultVars: server => {
const securityPlugin = server.newPlatform.setup.plugins.security;
if (!securityPlugin) {
Expand Down
16 changes: 0 additions & 16 deletions x-pack/legacy/plugins/security/public/documentation_links.js
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions x-pack/legacy/plugins/security/public/images/logout.svg
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions x-pack/legacy/plugins/security/public/images/person.svg
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions x-pack/legacy/plugins/security/public/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,6 @@ $secFormWidth: 460px;
// Public views
@import './views/index';

// Styles of Kibana Platform plugin
@import '../../../../plugins/security/public/index';
Copy link
Member Author

@azasypkin azasypkin Jan 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: looks like it's the only way to import style from platform plugin right now.


49 changes: 0 additions & 49 deletions x-pack/legacy/plugins/security/public/lib/__tests__/util.js
View file
Open in desktop

This file was deleted.

56 changes: 0 additions & 56 deletions x-pack/legacy/plugins/security/public/lib/api.ts
View file
Open in desktop

This file was deleted.

47 changes: 0 additions & 47 deletions x-pack/legacy/plugins/security/public/lib/api_keys_api.ts
View file
Open in desktop

This file was deleted.

58 changes: 0 additions & 58 deletions x-pack/legacy/plugins/security/public/lib/role_utils.ts
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions x-pack/legacy/plugins/security/public/lib/roles_api.ts
View file
Open in desktop

This file was deleted.

41 changes: 0 additions & 41 deletions x-pack/legacy/plugins/security/public/lib/transform_role_for_save.ts
View file
Open in desktop

This file was deleted.

Loading