[Dashboard] Empty screen redesign #53681

majagrubic · 2019-12-20T09:40:55Z

Summary

Redesigning empty screen according to: #51916 (comment)

Edit mode:

View mode:

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

kibanamachine · 2019-12-23T12:58:28Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: aabfcfd

History

💔 Build #16906 failed 7e6cb3b11991b33b1940976677493b83a5116279
💔 Build #16865 failed d5bb64a7e49c367eb1ae558b5f8c1b43db06c3cf

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2019-12-23T16:33:29Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 6a0c501

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2019-12-24T09:42:01Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: e65dbf5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ryankeairns

This is looking great, just a few small design changes which can be found and merged here: majagrubic#3

Thank you!

majagrubic · 2020-01-03T16:14:49Z

Jenkins, test this

majagrubic · 2020-01-03T16:43:26Z

@elasticmachine merge upstream

ryankeairns

LGTM, feedback captured in merged design PR.

majagrubic · 2020-01-05T17:36:42Z

@elasticmachine merge upstream

kibanamachine · 2020-01-05T18:54:04Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 80cd07b

History

💚 Build #17863 succeeded d99d82f
💔 Build #17823 failed 962f1a9995550ea8a4797937273fa3cb73619502
💔 Build #17796 failed 2bda9cb
💔 Build #17735 failed 42a477599bfa4000de9ea6d7f9592bbccb35c11a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mbondyra · 2020-01-06T10:23:10Z

LGTM, tested locally on Chrome and Safari 👌

* master: adds strict types to Alerting Client (elastic#53821) [Dashboard] Empty screen redesign (elastic#53681) Migrate config deprecations and `ShieldUser` functionality to the New Platform (elastic#53768)

…nsole-dependencies * 'master' of github.com:elastic/kibana: (33 commits) adds strict types to Alerting Client (elastic#53821) [Dashboard] Empty screen redesign (elastic#53681) Migrate config deprecations and `ShieldUser` functionality to the New Platform (elastic#53768) increase delay to make sure license refetched (elastic#53882) Allow custom NP plugin paths in production (elastic#53562) [Maps] show custom color ramps in legend (elastic#53780) [Lens] Expression type on document can be null (elastic#53883) [SIEM] [Detection engine] Add user permission to detection engine (elastic#53778) Update dependency @elastic/charts to v16.0.2 (elastic#52619) Set consistent EOL symbol in core API docs (elastic#53815) [Logs UI] Refactor query bar state to hooks (elastic#52656) [Maps] pass getFieldFormatter to DynamicTextProperty (elastic#53937) Invalidate alert API Key when generating a new one (elastic#53732) [Logs UI] HTTP API for log entries (elastic#53798) [kbn/pm] add caching to bootstrap (elastic#53622) adds createdAt and updatedAt fields to alerting (elastic#53793) [SR] Enable component integration tests (elastic#53893) Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data (elastic#53794) moved Task Manager server code under "server" directory (elastic#53777) Rename `/api/security/oidc` to `/api/security/oidc/callback`. (elastic#53886) ... # Conflicts: # yarn.lock

* Edit screen redesign * Edit screen redesign * Redesign view screen * Redesign view screen * Fixing type failure, and functional test * Updating failing functional tests * update dashboard empty styles * i18n fix * Updating failing snapshot Co-authored-by: Ryan Keairns <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

* Edit screen redesign * Edit screen redesign * Redesign view screen * Redesign view screen * Fixing type failure, and functional test * Updating failing functional tests * update dashboard empty styles * i18n fix * Updating failing snapshot Co-authored-by: Ryan Keairns <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Ryan Keairns <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

* master: allows Alerts to recover gracefully from Executor errors (elastic#53688) [Console] Fix OSS build (elastic#53885) migrate xsrf / version-check / custom-headers handlers to NP (elastic#53684) use NP deprecations in uiSettings (elastic#53755) adds strict types to Alerting Client (elastic#53821) [Dashboard] Empty screen redesign (elastic#53681) Migrate config deprecations and `ShieldUser` functionality to the New Platform (elastic#53768)

majagrubic requested a review from ryankeairns December 20, 2019 09:50

majagrubic force-pushed the empty-screen-redesign branch 2 times, most recently from 7e6cb3b to aabfcfd Compare December 23, 2019 11:39

elastic deleted a comment from elasticmachine Dec 23, 2019

ryankeairns reviewed Jan 2, 2020

View reviewed changes

majagrubic marked this pull request as ready for review January 3, 2020 10:52

majagrubic requested a review from a team January 3, 2020 10:52

majagrubic requested a review from a team as a code owner January 3, 2020 10:52

majagrubic added Feature:Dashboard Dashboard related features release_note:roadmap v8.0.0 v7.6.0 labels Jan 3, 2020

majagrubic requested review from a team as code owners January 3, 2020 14:56

majagrubic force-pushed the empty-screen-redesign branch from bb79933 to fc6b437 Compare January 3, 2020 15:08

majagrubic removed request for a team January 3, 2020 15:09

Maja Grubic and others added 7 commits January 3, 2020 15:14

Edit screen redesign

1336540

Redesign view screen

3610611

Fixing type failure, and functional test

b8ec1b2

Updating failing functional tests

6b5d721

update dashboard empty styles

3af229f

Edit screen redesign

b655dd0

Redesign view screen

8993232

majagrubic force-pushed the empty-screen-redesign branch 2 times, most recently from 487d7cf to 2bda9cb Compare January 3, 2020 15:20

i18n fix

2bda9cb

ryankeairns approved these changes Jan 3, 2020

View reviewed changes

Updating failing snapshot

d99d82f

majagrubic force-pushed the empty-screen-redesign branch from 962f1a9 to d99d82f Compare January 3, 2020 19:32

Merge branch 'master' into empty-screen-redesign

80cd07b

mbondyra approved these changes Jan 6, 2020

View reviewed changes

majagrubic merged commit 5b2a188 into elastic:master Jan 6, 2020

majagrubic deleted the empty-screen-redesign branch January 6, 2020 10:55

majagrubic mentioned this pull request Jan 6, 2020

[7.x] [Dashboard] Empty screen redesign (#53681) #54008

Merged

KOTungseth mentioned this pull request Jan 23, 2020

[DOCS] Empty dashboard screen #55727

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Dashboard] Empty screen redesign #53681

[Dashboard] Empty screen redesign #53681

Uh oh!

majagrubic commented Dec 20, 2019 •

edited

Loading

Uh oh!

kibanamachine commented Dec 23, 2019

Uh oh!

kibanamachine commented Dec 23, 2019

Uh oh!

kibanamachine commented Dec 24, 2019

Uh oh!

ryankeairns left a comment

Uh oh!

majagrubic commented Jan 3, 2020

Uh oh!

majagrubic commented Jan 3, 2020

Uh oh!

ryankeairns left a comment

Uh oh!

majagrubic commented Jan 5, 2020

Uh oh!

kibanamachine commented Jan 5, 2020

Uh oh!

mbondyra commented Jan 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[Dashboard] Empty screen redesign #53681

[Dashboard] Empty screen redesign #53681

Uh oh!

Conversation

majagrubic commented Dec 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

kibanamachine commented Dec 23, 2019

💔 Build Failed

History

Uh oh!

kibanamachine commented Dec 23, 2019

💔 Build Failed

Uh oh!

kibanamachine commented Dec 24, 2019

💚 Build Succeeded

Uh oh!

ryankeairns left a comment

Choose a reason for hiding this comment

Uh oh!

majagrubic commented Jan 3, 2020

Uh oh!

majagrubic commented Jan 3, 2020

Uh oh!

ryankeairns left a comment

Choose a reason for hiding this comment

Uh oh!

majagrubic commented Jan 5, 2020

Uh oh!

kibanamachine commented Jan 5, 2020

💚 Build Succeeded

History

Uh oh!

mbondyra commented Jan 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

majagrubic commented Dec 20, 2019 •

edited

Loading