[Uptime] NP Config / Index Pattern option#53341
Closed
andrewvc wants to merge 3 commits intoelastic:masterfrom
Closed
[Uptime] NP Config / Index Pattern option#53341andrewvc wants to merge 3 commits intoelastic:masterfrom
andrewvc wants to merge 3 commits intoelastic:masterfrom
Conversation
andrewvc
added
Feature:New Platform
enhancement
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
pgayvallet
reviewed
Dec 18, 2019
Contributor
pgayvallet
left a comment
pgayvallet
left a comment
There was a problem hiding this comment.
Follow up of our slack conversation
| export const config = { | ||
| schema: schema.object({ | ||
| enabled: schema.maybe(schema.boolean()), | ||
| indexPattern: schema.maybe(schema.string()), |
Contributor
There was a problem hiding this comment.
schema.string({ defaultValue: 'alt-heartbeat-*' }) and remove from config
Comment on lines
+17
to
+19
| console.log("X") | ||
| console.log("SET IT UP") | ||
| console.log("X") |
Contributor
There was a problem hiding this comment.
(remove and) Use PluginInitializerContext.logger if you need to log from NP
Comment on lines
+21
to
+23
| return Joi.object({ | ||
| enabled: Joi.boolean().default(true), | ||
| }) |
Contributor
There was a problem hiding this comment.
You will need to add the indexPattern property in the legacy configuration for now, as both plugins share the same NS
Contributor
Author
|
Closing in favor of #53550 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use NP for config and add the new
xpack.uptime.indexPatternoption.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers