Skip to content

Conversation

@sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Dec 17, 2019

Summary

REGRESSION. Caused by #49891.

The reason is caused by wrapping the layout with additional divs here: https://github.com/elastic/kibana/pull/49891/files#diff-1ca3346c218d8218751dbe59736eb72aR66

The default vis editor layout doesn't take all the window height:

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@sulemanof sulemanof requested a review from a team as a code owner December 17, 2019 14:54
@sulemanof sulemanof added release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.7.0 v8.0.0 labels Dec 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

width: 100%;
height: 100%;
}
height: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When exaclty was the regression introduced?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @majagrubic !
I've found the root cause and updated the PR description

@sulemanof
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix LGTM in Chrome, @sulemanof Can you be sure to check in IE11?

@sulemanof
Copy link
Contributor Author

Fix LGTM in Chrome, @sulemanof Can you be sure to check in IE11?

The current version of kibana is not supported in IE11:

image

Checked in Firefox & Edge, works fine:

layout

@sulemanof sulemanof merged commit c8a430a into elastic:master Dec 20, 2019
@sulemanof sulemanof deleted the fix/vis-editor-layout branch December 20, 2019 10:23
@flash1293
Copy link
Contributor

The current version of kibana is not supported in IE11:

@sulemanof It's still supported, you have to set csp.strict to false in your yml file to test. Could you verify everything works fine with this PR?

@sulemanof
Copy link
Contributor Author

@flash1293 thanks for the hint! But I still can't run kibana in IE, it is stuck loading...

image

@flash1293
Copy link
Contributor

Seems like there is something else off, I will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.6.0 v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants