[failedTests] fix reportMessageIter and add unit test #52886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
v8.0.0
release_note:skip
added 2 commits
December 12, 2019 09:36
Contributor
Author
|
Skipped flaky test: #36011 |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
brianseeders
approved these changes
Dec 13, 2019
This was referenced Dec 13, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Dec 13, 2019
* [failedTests] fix reportMessageIter and add unit test * update related snapshots
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Dec 13, 2019
* [failedTests] fix reportMessageIter and add unit test * update related snapshots
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welp, wrote too few tests in #52449 it seems and screenshots aren't being collected from JUnit reports because of a bug in the way they were being read. This fixes that and adds a test for that module.