Move top nav to NP#52877
Merged
lizozom merged 7 commits intoDec 16, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
lizozom
added
the
release_note:skip
lizozom
force-pushed
the
newplatform/navigation/move-topnav
branch
from
699f9ff to
33277a0
Compare
flash1293
approved these changes
Dec 13, 2019
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Graph changes LGTM, didn't test
streamich
approved these changes
Dec 13, 2019
Contributor
There was a problem hiding this comment.
Now that this file is empty, it can probably be deleted.
Contributor
Author
There was a problem hiding this comment.
Removing this one gave me trouble with plugin initialization.
I'll remove it once the SCSS moves to NP.
lizozom
force-pushed
the
newplatform/navigation/move-topnav
branch
from
7c8e868 to
c488259
Compare
ryankeairns
approved these changes
Dec 13, 2019
Contributor
ryankeairns
left a comment
ryankeairns
left a comment
There was a problem hiding this comment.
👍 LGTM, changed one SCSS import path.
added 5 commits
December 16, 2019 10:43
Removed old plugin code
lizozom
force-pushed
the
newplatform/navigation/move-topnav
branch
from
ce00dab to
cc271c1
Compare
added 2 commits
December 16, 2019 11:32
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Dec 16, 2019
* Move top nav to NP * TopNavMenu karma mock * Fixed lens test mocking Removed old plugin code * readme * Code review fixes * lint * ts
lizozom
pushed a commit
that referenced
this pull request
Dec 16, 2019
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Dec 17, 2019
This reverts commit daac96c.
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* Move top nav to NP * TopNavMenu karma mock * Fixed lens test mocking Removed old plugin code * readme * Code review fixes * lint * ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #51029
Depends on merging #52622
Move topnav to an NP plugin
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers