Skip to content

[7.x] Fixes the link to advanced settings in the telemetry opt-in notice banner (#52699) #52799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TinaHeiligers merged 1 commit into from
Dec 11, 2019
Merged

[7.x] Fixes the link to advanced settings in the telemetry opt-in notice banner (#52699) #52799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/legacy/core_plugins/telemetry/common/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,8 @@ export const TELEMETRY_STATS_TYPE = 'telemetry';
* @type {string}
*/
export const UI_METRIC_USAGE_TYPE = 'ui_metric';

/**
* Link to Advanced Settings.
*/
export const PATH_TO_ADVANCED_SETTINGS = 'kibana#/management/kibana/settings';
2 changes: 1 addition & 1 deletion ...re_plugins/telemetry/public/components/__snapshots__/opted_in_notice_banner.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion src/legacy/core_plugins/telemetry/public/components/opted_in_notice_banner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@
/* eslint @elastic/eui/href-or-on-click:0 */

import * as React from 'react';
import chrome from 'ui/chrome';
import { EuiButton, EuiLink, EuiCallOut, EuiSpacer } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n/react';
import { PATH_TO_ADVANCED_SETTINGS } from '../../common/constants';

interface Props {
onSeenBanner: () => any;
Expand Down Expand Up @@ -57,7 +59,10 @@ export class OptedInBanner extends React.PureComponent<Props> {
</EuiLink>
),
disableLink: (
<EuiLink href="#/management/kibana/settings" onClick={this.onLinkClick}>
<EuiLink
href={chrome.addBasePath(PATH_TO_ADVANCED_SETTINGS)}
onClick={this.onLinkClick}
>
<FormattedMessage
id="telemetry.telemetryOptedInDisableUsage"
defaultMessage="disable usage data here"
Expand Down