Fixes the link to advanced settings in the telemetry opt-in notice banner #52699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opt-in notice banner from all apps
TinaHeiligers
requested review from
a team,
Bamieh and
epixa
and removed request for
a team
Contributor
|
Pinging @elastic/pulse (Team:Pulse) |
TinaHeiligers
added
the
release_note:skip
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
TinaHeiligers
added a commit
to TinaHeiligers/kibana
that referenced
this pull request
Dec 11, 2019
…nner (elastic#52699) * Prepends base path to the link to advanced settings in the telemetry opt-in notice banner from all apps
lukeelmers
added
the
Team:Core
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves to #51833
The PR changes the link to advances settings in the telemetry notice banner from a relative path to an absolute path. We need an absolute path so that we can link to the right page from solution apps.
Demo:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately