Upgrade to [email protected] [table typescript types] #52688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerprall
added
v8.0.0
release_note:skip
7 tasks
chandlerprall
changed the title
chandlerprall
changed the title
lizozom
reviewed
Dec 12, 2019
Contributor
lizozom
left a comment
lizozom
left a comment
There was a problem hiding this comment.
@elastic/kibana-app-arch LGTM
pgayvallet
approved these changes
Dec 12, 2019
Contributor
pgayvallet
left a comment
pgayvallet
left a comment
There was a problem hiding this comment.
LGTM for platform changes
walterra
approved these changes
Dec 13, 2019
Contributor
walterra
left a comment
walterra
left a comment
There was a problem hiding this comment.
ML/transform changes LGTM. Thanks for this update, this should allow us to get rid of our custom types in a follow up!
lizozom
approved these changes
Dec 13, 2019
weltenwort
approved these changes
Dec 16, 2019
Member
weltenwort
left a comment
weltenwort
left a comment
There was a problem hiding this comment.
infra changes LGTM - thank you!
| }; | ||
|
|
||
| const StyledEuiBasicTable = euiStyled(EuiBasicTable)` | ||
| const StyledEuiBasicTable: typeof EuiBasicTable = euiStyled(EuiBasicTable as any)` |
Member
There was a problem hiding this comment.
Not pretty but I couldn't find a better way either 🤷♀️
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The two biggest changes here are icon snapshot updates (for accessibility, elastic/eui#2554) and typescript definitions for
EuiBasicTableandEuiInMemoryTable(elastic/eui#2428).When unifying Kibana's usage of eui tables with the new types, I avoided changes to run-time code, always preferring to mess only with the type definitions, usages, and in some cases avoiding the confusion with a
// @ts-ignore. The primary differences are:Itemeach row representsItem, and field rendering ensures the specified field exists on the item.Item. This, combined with TypeScript's lack of usage-based inference, led to a number of additionalas const.In addition, some apps (SIEM in particular) have defined a
Directionenum ofASC&DESCwhich caused problems in the sorting callbacks which expect the enum value, but the EUI table only guarantees a string literal of'asc' | 'desc'- TS enum values are nominally typed, as demonstrated by this typescript playground. I resolved those by updating the onSort callback to allowDirection | 'asc' | 'desc'.17.1.2Bug fixes
EuiCodeEditorcustom mode file error by initializing with existing mode (#2616)EuiIcondefault titles (#2632)17.1.1Bug fixes
EuiTreeViewand added truncation (#2627)17.1.0keyproperty inside theoptionsprop inEuiSelectableListcomponent (#2608)toolbarAdditionalControlsprop toEuiDataGridto allow for custom buttons in the toolbar (#2594)EuiBasicTable,EuiInMemoryTable, and related components (#2428)logoSecurityandappSecurityAnalyticsicons (#2613)Bug fixes
EuiDataGridwhen using keyboard shortcuts to paginate (#2602)EuiIconaccessibility by adding atitleprop and a defaultaria-label(#2554)EuiDataGrid's in-memory sorting of numeric columns when the cell data contains multiple digit groups (#2603)EuiBasicTable.paginationBaris hidden when there is no data andEuiPaginationis displayed even when there is only one page (#2598)EuiPopoverwas unmounted before calls to setState (#2614)