[Maps] Update license check & requests to use NP services #52641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindsun
added
blocked
Feature:New Platform
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
added 5 commits
December 12, 2019 10:29
…hange. Import new license id in meta
…-request # Conflicts: # x-pack/legacy/plugins/maps/index.js # x-pack/legacy/plugins/maps/public/kibana_services.js # x-pack/legacy/plugins/maps/public/meta.js # x-pack/legacy/plugins/maps/public/meta.test.js # x-pack/legacy/plugins/maps/server/plugin.js
kindsun
added
the
release_note:skip
Contributor
thomasneirynck
left a comment
thomasneirynck
left a comment
There was a problem hiding this comment.
Thanks!
Also, the tilemap-plugin in x-pack needs a similar refactoring. https://github.com/elastic/kibana/blob/8e9a8a84dccfa7965ce8a22362885e6cdef8b51f/x-pack/legacy/plugins/tilemap/index.js
added 3 commits
December 17, 2019 15:49
thomasneirynck
approved these changes
Dec 17, 2019
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Dec 18, 2019
) * Add back in np licensing changes previously pulled out of a separate pr * Watch license service and update local kibana service const obj. on change. Import new license id in meta * Update flow for initializing indexPatternServices while in this file * Clean up setup method. Add conditional subscribe of licensing * Review feedback. Use license getter instead of obj * Revert "Update flow for initializing indexPatternServices while in this file" This reverts commit 022f7dd. * Update meta test
kindsun
pushed a commit
that referenced
this pull request
Dec 18, 2019
…53362) * Add back in np licensing changes previously pulled out of a separate pr * Watch license service and update local kibana service const obj. on change. Import new license id in meta * Update flow for initializing indexPatternServices while in this file * Clean up setup method. Add conditional subscribe of licensing * Review feedback. Use license getter instead of obj * Revert "Update flow for initializing indexPatternServices while in this file" This reverts commit 022f7dd. * Update meta test
cjcenizal
pushed a commit
to cjcenizal/kibana
that referenced
this pull request
Dec 18, 2019
) * Add back in np licensing changes previously pulled out of a separate pr * Watch license service and update local kibana service const obj. on change. Import new license id in meta * Update flow for initializing indexPatternServices while in this file * Clean up setup method. Add conditional subscribe of licensing * Review feedback. Use license getter instead of obj * Revert "Update flow for initializing indexPatternServices while in this file" This reverts commit 022f7dd. * Update meta test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on the licensing functionality pulled out of #51683 and in response to this comment. This PR adds the capability to check the license on the server-side and supply the license to EMS from the client leveraging new platform services. Currently it's blocked by #52551