Skip to content

[ML] Fetch the latest job messages and enable sorting by time #52388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darnautov merged 3 commits into from
Dec 6, 2019
Merged

[ML] Fetch the latest job messages and enable sorting by time #52388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28fd701
[ML] add sorting support
darnautov Dec 6, 2019
b91adbc
[ML] change fetch sort to desc for anomaly detection jobs
darnautov Dec 6, 2019
e733d87
[ML] rename param
darnautov Dec 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions x-pack/legacy/plugins/ml/public/application/components/job_messages/job_messages.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import React, { FC } from 'react';

import { EuiSpacer, EuiBasicTable } from '@elastic/eui';
import { EuiSpacer, EuiInMemoryTable } from '@elastic/eui';
// @ts-ignore
import { formatDate } from '@elastic/eui/lib/services/format';
import { i18n } from '@kbn/i18n';
Expand Down Expand Up @@ -35,11 +35,13 @@ export const JobMessages: FC<JobMessagesProps> = ({ messages, loading, error })
width: `${theme.euiSizeL}`,
},
{
field: 'timestamp',
name: i18n.translate('xpack.ml.jobMessages.timeLabel', {
defaultMessage: 'Time',
}),
render: (message: any) => formatDate(message.timestamp, TIME_FORMAT),
render: (timestamp: number) => formatDate(timestamp, TIME_FORMAT),
width: '120px',
sortable: true,
},
{
field: 'node_name',
Expand All @@ -57,13 +59,22 @@ export const JobMessages: FC<JobMessagesProps> = ({ messages, loading, error })
},
];

const defaultSorting = {
sort: {
field: 'timestamp',
direction: 'asc',
},
};

return (
<>
<EuiSpacer size="s" />
<EuiBasicTable
<EuiInMemoryTable
className="job-messages-table"
items={messages}
columns={columns}
sorting={defaultSorting}
// @ts-ignore
compressed={true}
loading={loading}
error={error}
Expand Down
2 changes: 1 addition & 1 deletion x-pack/legacy/plugins/ml/server/models/job_audit_messages/job_audit_messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export function jobAuditMessagesProvider(callWithRequest) {
body:
{
sort: [
{ timestamp: { order: 'asc' } },
{ timestamp: { order: 'desc' } },
{ job_id: { order: 'asc' } }
],
query
Expand Down