Skip to content

[7.5] [ML] Functional tests - increase stability of source selection (#51988) #52287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pheyos merged 1 commit into from
Dec 5, 2019
Merged

[7.5] [ML] Functional tests - increase stability of source selection (#51988) #52287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/test/functional/apps/machine_learning/anomaly_detection/advanced_job.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ export default function({ getService }: FtrProviderContext) {
});

it('job creation loads the job type selection page', async () => {
await ml.jobSourceSelection.selectSource(testData.jobSource);
await ml.jobSourceSelection.selectSourceForAnomalyDetectionJob(testData.jobSource);
});

it('job creation loads the advanced job wizard page', async () => {
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/apps/machine_learning/anomaly_detection/multi_metric_job.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export default function({ getService }: FtrProviderContext) {
});

it('job creation loads the job type selection page', async () => {
await ml.jobSourceSelection.selectSource('farequote');
await ml.jobSourceSelection.selectSourceForAnomalyDetectionJob('farequote');
});

it('job creation loads the multi metric job wizard page', async () => {
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/apps/machine_learning/anomaly_detection/population_job.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export default function({ getService }: FtrProviderContext) {
});

it('job creation loads the job type selection page', async () => {
await ml.jobSourceSelection.selectSource('ecommerce');
await ml.jobSourceSelection.selectSourceForAnomalyDetectionJob('ecommerce');
});

it('job creation loads the population job wizard page', async () => {
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/apps/machine_learning/anomaly_detection/saved_search_job.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ export default function({ getService }: FtrProviderContext) {
});

it('job creation loads the job type selection page', async () => {
await ml.jobSourceSelection.selectSource(testData.jobSource);
await ml.jobSourceSelection.selectSourceForAnomalyDetectionJob(testData.jobSource);
});

it('job creation loads the multi metric job wizard page', async () => {
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/apps/machine_learning/anomaly_detection/single_metric_job.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export default function({ getService }: FtrProviderContext) {
});

it('job creation loads the job type selection page', async () => {
await ml.jobSourceSelection.selectSource('farequote');
await ml.jobSourceSelection.selectSourceForAnomalyDetectionJob('farequote');
});

it('job creation loads the single metric job wizard page', async () => {
Expand Down
13 changes: 10 additions & 3 deletions x-pack/test/functional/services/machine_learning/job_source_selection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { FtrProviderContext } from '../../ftr_provider_context';

export function MachineLearningJobSourceSelectionProvider({ getService }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const retry = getService('retry');

return {
async assertSourceListContainsEntry(sourceName: string) {
Expand All @@ -21,10 +22,16 @@ export function MachineLearningJobSourceSelectionProvider({ getService }: FtrPro
await this.assertSourceListContainsEntry(sourceName);
},

async selectSource(sourceName: string) {
async selectSource(sourceName: string, nextPageSubj: string) {
await this.filterSourceSelection(sourceName);
await testSubjects.clickWhenNotDisabled(`savedObjectTitle${sourceName}`);
await testSubjects.existOrFail('mlPageJobTypeSelection');
await retry.tryForTime(30 * 1000, async () => {
await testSubjects.clickWhenNotDisabled(`savedObjectTitle${sourceName}`);
await testSubjects.existOrFail(nextPageSubj, { timeout: 10 * 1000 });
});
},

async selectSourceForAnomalyDetectionJob(sourceName: string) {
await this.selectSource(sourceName, 'mlPageJobTypeSelection');
},
};
}