Skip to content

Fix import causing Kibana to crash in IE11. #52248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2019
Merged

Fix import causing Kibana to crash in IE11. #52248

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34a7b05
Fix import causing Kibana to crash in IE11.
lukeelmers Dec 5, 2019
f4d650e
Add TODO comment.
lukeelmers Dec 5, 2019
00ab512
Merge branch 'master' into fix/ie11
elasticmachine Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion x-pack/legacy/plugins/canvas/server/lib/build_embeddable_filters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@
import { Filter } from '../../types';
// @ts-ignore Untyped Local
import { buildBoolArray } from './build_bool_array';
import { TimeRange, esFilters } from '../../../../../../src/plugins/data/server';

// TODO: We should be importing from `data/server` below instead of `data/common`, but
// need to keep `data/common` since the contents of this file are currently imported
// by the browser. This file should probably be refactored so that the pieces required
// on the client live in a `public` directory instead. See kibana/issues/52343
// eslint-disable-next-line @kbn/eslint/no-restricted-paths
import { TimeRange, esFilters } from '../../../../../../src/plugins/data/common';

export interface EmbeddableFilterInput {
filters: esFilters.Filter[];
Expand Down