[Canvas] Move workpad api routes to New Platform#51116
[Canvas] Move workpad api routes to New Platform#51116crob611 merged 7 commits intoelastic:masterfrom
Conversation
crob611
added
Team:Presentation
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
joshdover
left a comment
joshdover
left a comment
There was a problem hiding this comment.
Since you already have a server-side shim, any reason not to keep these routes in that shimmed plugin (but still using the New Platform router)?
By keeping it in the shimmed legacy plugin you'll be able to move the entire legacy server code over at once which may make the final migration step a bit easier.
| } | ||
|
|
||
| public stop() { | ||
| this.initializerContext.logger.get().debug('Stopping Canvas plugin'); |
There was a problem hiding this comment.
FYI, Core already logs messages for each plugin lifecycle method, so these may be superfluous.
| */ | ||
|
|
||
| import sinon from 'sinon'; | ||
| import Sinon from 'sinon'; |
| statusCode: error.output.statusCode, | ||
| }); | ||
| } | ||
| return response.badRequest({ body: error }); |
There was a problem hiding this comment.
If it's an unexpected error, I think we should use response.internalError for a 500 error.
| */ | ||
|
|
||
| import sinon from 'sinon'; | ||
| import Sinon from 'sinon'; |
| /** | ||
| * Represents Code Plugin instance that will be managed by the Kibana plugin system. | ||
| */ | ||
| export class CanvasPlugin { |
There was a problem hiding this comment.
You should import and implement the Plugin interface from src/core/server here.
💚 Build Succeeded |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
poffdeluxe
left a comment
poffdeluxe
left a comment
There was a problem hiding this comment.
lgtm -- tested on sample workpad data and it worked great
💚 Build Succeeded |
* Move workpad api routes to New Platform * Cleanup * Clean up/Pr Feedback * Adding missing dependency to tests * Fix typecheck * Loosen workpad schema restrictions
4 participants
Summary
This PR creates the Canvas plugin that will be loaded via the New Platform.
Also adds all of the routes for the workpads api to this new plugin and removes them from the canvas legacy plugin. Important note here is this also adds validation to all of the params or bodys of those requests, so please test whatever ways you can think of that these routes might be called to ensure they are never called in an incorrect way with params that will fail validation.
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers