[ML] Transform: Fix use of saved search in pivot wizard. #51079

walterra · 2019-11-19T17:49:47Z

Summary

Fixes applying saved searches in the transform wizard. Previously, upon initializing the transform wizard's state, we would miss passing on the initialized data from kibanaContext. The resulting bug was that saved search were not applied in the generated transform config and source preview table.

Introduces useKibanaContext custom hook, in combination with the RenderOnlyWithInitializedKibanaContext component we don't need to check in components further down if kibanaContext was already initialized. We already have a similar useKibanaContext in plugins/ml but plugins/transform was missing a similar custom hook.
Removes some unused commented code
Adds functional tests which create a transform based on a saved search.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-11-19T17:49:50Z

Pinging @elastic/ml-ui (:ml)

elasticmachine · 2019-11-19T18:51:28Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: ca00c7babe2259251a37ca326a4b33a9be6a89e3

elasticmachine · 2019-11-20T10:02:07Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 8b4fd442586cc6c5ff65c79dc41b8c03c7311017

peteharverson · 2019-11-20T11:03:20Z

The saved search now seems to be getting applied in the wizard, but it looks to me like it isn't used in the preview table in the list page. Here my saved search matches against 12 instances from two regions, but the preview table lists all instances across all regions:

peteharverson · 2019-11-20T11:13:44Z

x-pack/test/functional/apps/transform/creation_saved_search.ts

Typo - should refer to the avg(responsetime) agg I think.

Fixed in a2fc19a.

pheyos

Great stuff 🎉
Left a couple suggestions around the tests.

...ublic/app/sections/create_transform/components/source_index_preview/source_index_preview.tsx

...gins/transform/public/app/sections/create_transform/components/step_define/pivot_preview.tsx

x-pack/test/functional/apps/transform/creation_index_pattern.ts

x-pack/test/functional/apps/transform/creation_saved_search.ts

x-pack/test/functional/services/transform_ui/wizard.ts

elasticmachine · 2019-11-20T11:56:53Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: d2fc96e457f8481ea2053eb9423a8cf88fc31847

pheyos

Also, I've noticed that the preview in the row expansion is still not taking the saved search into account, e.g. this is filtered by airline:A*:

However, the actual data in the destination index is correct.

pheyos

Failed test: Error: expected 'Ahmed Al,Eddie,Robert' to equal 'Ahmed Al,Kamal,Robert'
It seems that the source preview doesn't load the same data each time. Probably because we're not sorting in the ES query and in that case ES doesn't give guarantees on the order.

alvarezmelissa87

Code LGTM once tests have been updated and typo fixed 👌

walterra · 2019-11-22T11:32:23Z

@peteharverson I fixed the filtered preview in the transform list in 8c54cdb.

walterra · 2019-11-22T11:38:25Z

@pheyos Addressed your comments. I changed the source table assertion for the index based tests to only check for the number of rows and columns. The preview on the management page should now be filtered correctly too.

elasticmachine · 2019-11-22T12:46:01Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 8841e315eb96a558cb5b80de4567cae7080fc9b7

pheyos

LGTM
I think the validation for number of columns and rows could be also useful (in addition to the existing validations) for
a) the pivot preview table
b) the saved search transforms
but this can be done in a follow-up.

elasticmachine · 2019-11-22T19:34:17Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: b043e44bf5ca66ba748061d361b41d28e034df13

walterra · 2019-11-22T20:14:40Z

retest

walterra · 2019-11-22T20:23:53Z

@elasticmachine merge upstream

elasticmachine · 2019-11-22T21:49:43Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: d478e38a062dfe63584db8e8e700b3992942481d

… search.

elasticmachine · 2019-11-23T21:48:59Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 3a47245

elasticmachine · 2019-11-23T22:25:48Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ef48949

Fixes applying saved searches in the transform wizard. Previously, upon initializing the transform wizard's state, we would miss passing on the initialized data from kibanaContext. The resulting bug was that saved search were not applied in the generated transform config and source preview table.

…1555) Fixes applying saved searches in the transform wizard. Previously, upon initializing the transform wizard's state, we would miss passing on the initialized data from kibanaContext. The resulting bug was that saved search were not applied in the generated transform config and source preview table.

Fixes applying saved searches in the transform wizard. Previously, upon initializing the transform wizard's state, we would miss passing on the initialized data from kibanaContext. The resulting bug was that saved search were not applied in the generated transform config and source preview table.

… (#52210) * [ML] Transform: Fix use of saved search in pivot wizard. (#51079) Fixes applying saved searches in the transform wizard. Previously, upon initializing the transform wizard's state, we would miss passing on the initialized data from kibanaContext. The resulting bug was that saved search were not applied in the generated transform config and source preview table. * [ML] Fix search for Transforms and Analytics tables (#52163) * [ML] fix TransformTable init * [ML] fix Analytics table * [ML] Fix table imports.

walterra added bug Fixes for quality problems that affect the customer experience regression release_note:fix :ml test_xpack_functional v8.0.0 Feature:Transforms Transforms v7.6.0 v7.5.1 labels Nov 19, 2019

walterra requested review from alvarezmelissa87, darnautov, jgowdyelastic, peteharverson and pheyos November 19, 2019 17:49

walterra requested a review from a team as a code owner November 19, 2019 17:49

walterra self-assigned this Nov 19, 2019

peteharverson reviewed Nov 20, 2019

View reviewed changes

pheyos requested changes Nov 20, 2019

View reviewed changes

pheyos reviewed Nov 20, 2019

View reviewed changes

alvarezmelissa87 reviewed Nov 20, 2019

View reviewed changes

pheyos approved these changes Nov 22, 2019

View reviewed changes

walterra added 10 commits November 23, 2019 21:01

[ML] Fix wizard picking up saved search.

36bd3c6

[ML] Adds functional tests to assert transform creation using a saved…

68ad7e1

… search.

[transform] Fix query filter in management preview tab.

e0bc589

[transform] Fix copy-paste text error.

27c64fb

[transform] Fix rowProp data-test-subjs.

2c34b4d

[transform] Review feedback: Restructure functional tests.

cc3d679

[transform] Review feedback: Make expected values a string array.

e57bd39

[transform] Review feedback: Fixes flaky table assertion.

81e0eb0

[transform] Update snapshots.

a353303

[transform] Fix types.

3a47245

walterra force-pushed the ml-fix-transform-saved-search branch from d478e38 to 3a47245 Compare November 23, 2019 20:17

[transform] Remove deprecated file.

ef48949

walterra merged commit b5133b5 into elastic:master Nov 24, 2019

walterra deleted the ml-fix-transform-saved-search branch November 24, 2019 07:36

walterra mentioned this pull request Nov 24, 2019

[7.x] [ML] Transform: Fix use of saved search in pivot wizard. (#51079) #51555

Merged

walterra added the backport pending label Nov 24, 2019

darnautov mentioned this pull request Dec 4, 2019

[ML] Fix search for Transforms and Analytics tables #52163

Merged

4 tasks

walterra mentioned this pull request Dec 4, 2019

[7.5] [ML] Transform: Fix use of saved search in pivot wizard. (#51079) #52210

Merged

peteharverson removed the backport pending label Dec 5, 2019

[ML] Transform: Fix use of saved search in pivot wizard. #51079

[ML] Transform: Fix use of saved search in pivot wizard. #51079

Uh oh!

Conversation

walterra commented Nov 19, 2019

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Nov 19, 2019

Uh oh!

elasticmachine commented Nov 19, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 20, 2019

💔 Build Failed

Uh oh!

peteharverson commented Nov 20, 2019

Uh oh!

peteharverson Nov 20, 2019

Choose a reason for hiding this comment

Uh oh!

walterra Nov 22, 2019

Choose a reason for hiding this comment

Uh oh!

pheyos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Nov 20, 2019

💔 Build Failed

Uh oh!

pheyos left a comment

Choose a reason for hiding this comment

Uh oh!

pheyos left a comment

Choose a reason for hiding this comment

Uh oh!

alvarezmelissa87 left a comment

Choose a reason for hiding this comment

Uh oh!

walterra commented Nov 22, 2019

Uh oh!

walterra commented Nov 22, 2019

Uh oh!

elasticmachine commented Nov 22, 2019

💔 Build Failed

Uh oh!

pheyos left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 22, 2019

💔 Build Failed

Uh oh!

walterra commented Nov 22, 2019

Uh oh!

walterra commented Nov 22, 2019

Uh oh!

elasticmachine commented Nov 22, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Nov 23, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 23, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects