Np kibana plugin home feature catalogue

[TinaHeiligers]

Summary

Moves the feature_catalogue plugin (introduced in PR48818 ) into the home plugin.

Dev Docs

The ui/registries/feature_catalogue module has been deprecated for removal in 8.0

Plugins wishing to migrate may remove their usage of ui/registries/feature_catalogue and rely on either:

// For legacy plugins
import { npSetup } from 'ui/new_platform';
npSetup.plugins.home.featureCatalogue.register(/* same details here */);

// For new plugins: first add 'home` to the list of `optionalPlugins` 
// in your kibana.json file. Then access the plugin directly in `setup`:

class MyPlugin {
  setup(core, plugins) {
    if (plugins.home) {
      plugins.home.featureCatalogue.register(/* same details here. */);
    }
  }
}

Note that the old module supported providing a Angular DI function to receive Angular dependencies. This is no longer supported as we migrate away from Angular.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
  - [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: cbb950c

[TinaHeiligers]

Looks like this PR is built on top of #50444, right? When the other one is merged, this one will become easier to review.
@flash1293 PR #50444 has been merged. There are fewer files with changes now and this PR should be easier to review. For consistency, I renames the server plugin from HomePlugin to HomeServerPlugin. LMK if that shouldn't be done in this PR.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: 68159e5

[TinaHeiligers]

@elasticmachine merge upstream

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: f4548b2c0808367b4282138d058625dac178d832

[flash1293]

Code changes LGTM, didn't pull down to test

[legrego]

Spaces changes LGTM

[TinaHeiligers]

@joshdover I need a LGTM from the platform team before I can merge this PR. All this PR does is move the feature_catalogue plugin code to the home plugin as a service in the public folder.

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 2fad345

[joshdover]

Looks great! Just two small suggestions.

I think it might be clearer if the services directory had top-level directories for each service so the source files don't get mixed up. For example:

services/
  feature_catalogue/
    index.ts
    feature_catalogue_registry.ts
  other_service/
    index.ts
    other_services.ts
  index.ts

May want to change the server-side as well.

[TinaHeiligers]

Looks great! Just two small suggestions.

I think it might be clearer if the services directory had top-level directories for each service so the source files don't get mixed up. For example:

services/
  feature_catalogue/
    index.ts
    feature_catalogue_registry.ts
  other_service/
    index.ts
    other_services.ts
  index.ts

May want to change the server-side as well.

I was thinking the same thing! I'll do that in this PR because the next task is to migrate the sample data and that's going to be a much larger effort.

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 83a43bf

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 9a73942