Typescriptify and shim kbn_tp_run_pipeline test plugin #50645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💔 Build Failed
|
Contributor
Author
|
retest |
Contributor
💔 Build Failed
|
Dosant
force-pushed
the
dev/typscriptify-expression-service-functional-tests
branch
from
793670b to
3798959
Compare
Contributor
💔 Build Failed
|
Dosant
force-pushed
the
dev/typscriptify-expression-service-functional-tests
branch
from
25275ad to
c0dbb8c
Compare
Contributor
💔 Build Failed
|
Contributor
💔 Build Failed
|
Dosant
force-pushed
the
dev/typscriptify-expression-service-functional-tests
branch
from
d32033a to
08b40d0
Compare
Contributor
💚 Build Succeeded
|
Dosant
force-pushed
the
dev/typscriptify-expression-service-functional-tests
branch
from
08b40d0 to
2a9911d
Compare
Dosant
changed the title
Dosant
changed the title
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Dosant
added
the
release_note:skip
Contributor
💔 Build Failed |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
ppisljar
approved these changes
Nov 26, 2019
Contributor
ppisljar
left a comment
ppisljar
left a comment
There was a problem hiding this comment.
LGTM, one small change requested.
test/interpreter_functional/plugins/kbn_tp_run_pipeline/public/index.ts
Outdated
Show resolved
Hide resolved
…f github.com:Dosant/kibana into dev/typscriptify-expression-service-functional-tests
…ify-expression-service-functional-tests
Contributor
💚 Build Succeeded |
Dosant
deleted the
dev/typscriptify-expression-service-functional-tests
branch
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Nov 26, 2019
* Typscriptify and shim kbn_tp_run_pipeline test plugin * fix imports to not re-export ‘legacy’ from root of plugin
Dosant
added a commit
that referenced
this pull request
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Typescriptify and shim kbn_tp_run_pipeline test plugin
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers