Feature/issue 44550 new details panel and location map #50518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💔 Build Failed |
…into feature/issue-44550--new-details-panel-and-location-map
…nel' into feature/issue-44550--new-details-panel-and-location-map
Contributor
💔 Build Failed |
shahzad31
added
the
Team:Uptime - DEPRECATED
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
|
Some initial thoughts after loading up this patch:
|
Contributor
Author
Eventually it should look like this, so space will be mitigated in upcoming PR.
|
justinkambic
approved these changes
Dec 12, 2019
Contributor
justinkambic
left a comment
justinkambic
left a comment
There was a problem hiding this comment.
Left some minor comments and questions, but on the whole this LGTM! Great work!
...legacy/plugins/uptime/public/components/functional/location_map/embeddables/embedded_map.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/uptime/server/lib/adapters/monitors/elasticsearch_monitors_adapter.ts
Show resolved
Hide resolved
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
shahzad31
deleted the
feature/issue-44550--new-details-panel-and-location-map
branch
shahzad31
added a commit
that referenced
this pull request
Dec 18, 2019
…#53095) * Feature/issue 44550 new details panel and location map (#50518) * update * added an embeddable maps * update map config * added options to disable zoom, hide tool tips, widgets/overlays in embeddable maps * added options to disable zoom, hide tool tips, widgets/overlays in embeddable maps * added bool option to hide header * revert panel changes * update panel * update map * added disable interactive * update uptime embeddable * update redux state and removed widget over lay hiding * refactor widget overlay prop * update layout * update rest API * remove maps code * update components * update up/down points on map * update snaps * fixed type * update request * update request to include rnage * fix tests * utilize newly added setLayers method * remove unused code * refactor code * Remove unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #51449
This PR will add location map to details page to display each observer location on the map.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers