[SIEM] Fixes inspect cypress tests#50510
Merged
MadameSheema merged 1 commit intoelastic:masterfrom Nov 14, 2019
Merged
Conversation
MadameSheema
requested review from
andrew-goldstein,
patrykkopycinski and
stephmilovic
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
MadameSheema
added
the
release_note:skip
patrykkopycinski
approved these changes
Nov 13, 2019
Contributor
💔 Build Failed
|
andrew-goldstein
approved these changes
Nov 13, 2019
Contributor
andrew-goldstein
left a comment
andrew-goldstein
left a comment
There was a problem hiding this comment.
checked out master, ran inspect.sepc.ts, got 🔴 results for inspects the Top DNS Domains Table and inspects the Events Table tests , then checked out this PR, ran them again and got 💚 😄
LGTM
MadameSheema
force-pushed
the
inspect-fixes
branch
from
79bb05f to
406c37f
Compare
Contributor
💚 Build Succeeded |
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Nov 14, 2019
MadameSheema
added a commit
that referenced
this pull request
Nov 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we are fixing the failing inspect cypress tests:
Checklist
- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately