[Canvas][Docs] Updates function reference#50393
Conversation
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
|
Pinging @elastic/kibana-docs (Team:Docs) |
KOTungseth
left a comment
There was a problem hiding this comment.
Nice PR! I have some small suggestions, but otherwise LGTM.
There was a problem hiding this comment.
Is this supposed to be a question?
There was a problem hiding this comment.
Yeah, some help descriptions of arguments that take a boolean value are written in the form of a question to indicate true as yes and false as no. Should we not do this?
There was a problem hiding this comment.
Probably don't need to fix in this PR, or maybe at all, but my writer brain is flagging from which. I'm not sure if we care about using British English in our docs, but from which definitely fits in the British English realm.
There was a problem hiding this comment.
I'm thinking these are on purpose now... if so, please ignore all of my comments.
There was a problem hiding this comment.
When would I want to use a specialized function? Maybe add that information too?
There was a problem hiding this comment.
We should probably go into detail in the expression language docs instead of in this help text. Basically if I have a datatable and I want to add a render as="plot" for instance at the end, it won't work without using the specialized plot function.
bd2f9a3 to
32e6ee5
Compare
32e6ee5 to
61ab45c
Compare
Summary
[skip-ci]
This updates the function reference using the content generated in #49402.
Changes:
“)/close (”) double quote with straight (") double quotesChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers