Move @kbn/es-query into data plugin - es-query folder #50182

alexwizp · 2019-11-11T17:34:45Z

Summary

What was done in this PR:

move es-query/es-query into new platform;
new namespace was created for es-query code. Now all code related to es-query located in esQuery namespace;
tests were migrated from Mocha -> Jest;

Dev Docs

Relocated `@kbn/es-query` package to `data` plugin

The @kbn/es-query package has been moved to src/plugins/data and is available under the esQuery namespace on both the client and the server.

// old
import {
  buildEsQuery,
  EsQueryConfig,
  buildQueryFromFilters,
  luceneStringToDsl,
  decorateQuery,
  getEsQueryConfig,
} from '@kbn/es-query';

// new
import { esQuery } from 'src/plugins/data/public'; // or `src/plugins/data/server`
esQuery.buildEsQuery(...);

alexwizp · 2019-11-13T08:50:36Z

retest

alvarezmelissa87 · 2019-11-14T17:15:08Z

Gave this a test and I wasn't able to load Kibana. Kept getting this error:

With this console error:

elasticmachine · 2019-11-14T17:25:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: c7a2a6b

elasticmachine · 2019-11-14T21:47:45Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: cbddb92

lukeelmers

Tested locally & no other concerns on my end.

# Conflicts: # x-pack/legacy/plugins/siem/public/components/timeline/helpers.tsx # x-pack/legacy/plugins/siem/public/lib/keury/index.ts

lizozom · 2019-11-15T08:23:59Z

@alvarezmelissa87 if you could test once build passes

elasticmachine · 2019-11-15T10:03:06Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 73fdbd6

alexwizp · 2019-11-15T12:33:44Z

@Bargs @TinaHeiligers @alvarezmelissa87 could you please give me a final review?

alvarezmelissa87

Gave this a test and LGTM ⚡️

TinaHeiligers

LGTM

* Move @kbn/es-query into data plugin - es-query * fix eslint issues * Fix PR comments * fix CI * fix Ci * remove extra ts-ignore * fix imports * fix imports * Test importing from data/public and casting to ES Field Types. * Test importing from data/public and casting to ES Field Types. # Conflicts: # src/legacy/core_plugins/data/public/index_patterns/index_patterns/index_pattern.tsx # x-pack/legacy/plugins/siem/public/components/timeline/helpers.test.tsx # x-pack/legacy/plugins/siem/public/components/timeline/helpers.tsx # x-pack/legacy/plugins/siem/public/lib/keury/index.ts # x-pack/legacy/plugins/siem/public/pages/hosts/details/index.tsx # x-pack/legacy/plugins/siem/public/pages/hosts/hosts.tsx # x-pack/legacy/plugins/siem/public/pages/network/ip_details/index.tsx

…50824) * Move @kbn/es-query into data plugin - es-query folder (#50182) * Move @kbn/es-query into data plugin - es-query * fix eslint issues * Fix PR comments * fix CI * fix Ci * remove extra ts-ignore * fix imports * fix imports * Test importing from data/public and casting to ES Field Types. * Test importing from data/public and casting to ES Field Types. # Conflicts: # src/legacy/core_plugins/data/public/index_patterns/index_patterns/index_pattern.tsx # x-pack/legacy/plugins/siem/public/components/timeline/helpers.test.tsx # x-pack/legacy/plugins/siem/public/components/timeline/helpers.tsx # x-pack/legacy/plugins/siem/public/lib/keury/index.ts # x-pack/legacy/plugins/siem/public/pages/hosts/details/index.tsx # x-pack/legacy/plugins/siem/public/pages/hosts/hosts.tsx # x-pack/legacy/plugins/siem/public/pages/network/ip_details/index.tsx * fix merge conflicts

…her [skip ci] * upstream/master: (54 commits) allows plugins to define validation schema for "enabled" flag (elastic#50286) Add retry to find.existsByDisplayedByCssSelector (elastic#48734) [i18n] integrate latest translations (elastic#50864) ui/resize_checker 👉 src/plugins/kibana_utils (elastic#44750) Fix @reach/router types (elastic#50863) [ML] Adding ML node warning to overview and analytics pages (elastic#50766) Bump storybook dependencies (elastic#50752) [APM Replace usage of idx with optional chaining (elastic#50849) [SIEM] Fix eslint errors (elastic#49713) Improve "Browser client is out of date" error message (elastic#50296) [SIEM][Detection Engine] REST API improvements and changes from UI/UX feedback (elastic#50797) Move @kbn/es-query into data plugin - es-query folder (elastic#50182) Index Management new platform migration (elastic#49359) Increase retry for cloud snapshot to finish (elastic#50781) Removing EuiCode from inside EuiPanel (elastic#50683) [SIEM] Tests for search_after and bulk index (elastic#50129) Make babel understand TypeScript 3.7 syntax (elastic#50772) Fixing mocha tests and broken password change status codes (elastic#50704) [Canvas] Use compressed forms in sidebar (elastic#49419) Add labels to shell scripts in Jenkins (elastic#49657) ...

alexwizp self-assigned this Nov 11, 2019

lukeelmers mentioned this pull request Nov 11, 2019

Move @kbn/es-query into data plugin #42885

Closed

10 tasks

alexwizp added the WIP Work in progress label Nov 11, 2019

alexwizp changed the title ~~Move @kbn/es-query into data plugin - es-query folder~~ [WIP] Move @kbn/es-query into data plugin - es-query folder Nov 11, 2019

alexwizp force-pushed the es-query branch 4 times, most recently from d8b3a34 to b5abc40 Compare November 12, 2019 12:57

alexwizp requested review from Bargs, lizozom and ppisljar November 12, 2019 12:58

elastic deleted a comment from elasticmachine Nov 12, 2019

alexwizp force-pushed the es-query branch 2 times, most recently from 72cf022 to 0765f00 Compare November 12, 2019 14:09

elastic deleted a comment from elasticmachine Nov 12, 2019

alexwizp force-pushed the es-query branch from 0765f00 to 2f8a662 Compare November 12, 2019 14:49

elastic deleted a comment from elasticmachine Nov 12, 2019

alexwizp force-pushed the es-query branch 2 times, most recently from f7f4d37 to dd7a342 Compare November 12, 2019 20:16

elastic deleted a comment from elasticmachine Nov 12, 2019

alexwizp force-pushed the es-query branch 2 times, most recently from 1d11e66 to 61e89b3 Compare November 13, 2019 08:23

elastic deleted a comment from elasticmachine Nov 13, 2019

alexwizp marked this pull request as ready for review November 13, 2019 08:51

alexwizp requested a review from a team November 13, 2019 08:51

Merge remote-tracking branch 'upstream/master' into es-query

c7a2a6b

alexwizp force-pushed the es-query branch from 053c054 to c7a2a6b Compare November 14, 2019 16:19

Test importing from data/public and casting to ES Field Types.

cbddb92

lukeelmers approved these changes Nov 14, 2019

View reviewed changes

alexwizp added 3 commits November 15, 2019 11:07

Merge remote-tracking branch 'upstream/master' into es-query

3cba0a7

# Conflicts: # x-pack/legacy/plugins/siem/public/components/timeline/helpers.tsx # x-pack/legacy/plugins/siem/public/lib/keury/index.ts

Merge remote-tracking branch 'upstream/master' into es-query

a5ddbc2

Merge remote-tracking branch 'origin/es-query' into es-query

0ba8ea0

Test importing from data/public and casting to ES Field Types.

73fdbd6

alvarezmelissa87 approved these changes Nov 15, 2019

View reviewed changes

TinaHeiligers approved these changes Nov 15, 2019

View reviewed changes

Bargs removed their request for review November 15, 2019 20:07

alexwizp merged commit 9769be3 into elastic:master Nov 15, 2019

alexwizp mentioned this pull request Nov 15, 2019

[7.x] Move @kbn/es-query into data plugin - es-query folder (#50182) #50824

Merged

FrankHassanabad mentioned this pull request Nov 18, 2019

Kibana throws an error after logging in at IE11 #50927

Closed

This was referenced Dec 5, 2019

Fix import causing Kibana to crash in IE11. #52248

Merged

[Canvas] Relocate pieces of buildEmbeddableFilters which are required by the client. #52343

Closed

lukeelmers added release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. and removed release_note:skip Skip the PR/issue when compiling release notes labels Dec 11, 2019

lukeelmers mentioned this pull request Dec 11, 2019

[Data Plugin]: Remove export * for common code from public/server index files #52821

Merged

alexwizp deleted the es-query branch January 4, 2020 08:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move @kbn/es-query into data plugin - es-query folder #50182

Move @kbn/es-query into data plugin - es-query folder #50182

Uh oh!

alexwizp commented Nov 11, 2019 •

edited by lukeelmers

Loading

Uh oh!

alexwizp commented Nov 13, 2019

Uh oh!

alvarezmelissa87 commented Nov 14, 2019

Uh oh!

elasticmachine commented Nov 14, 2019

Uh oh!

elasticmachine commented Nov 14, 2019

Uh oh!

lukeelmers left a comment

Uh oh!

lizozom commented Nov 15, 2019

Uh oh!

elasticmachine commented Nov 15, 2019

Uh oh!

alexwizp commented Nov 15, 2019

Uh oh!

alvarezmelissa87 left a comment

Uh oh!

TinaHeiligers left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Move @kbn/es-query into data plugin - es-query folder #50182

Move @kbn/es-query into data plugin - es-query folder #50182

Uh oh!

Conversation

alexwizp commented Nov 11, 2019 • edited by lukeelmers Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Dev Docs

Relocated @kbn/es-query package to data plugin

Uh oh!

alexwizp commented Nov 13, 2019

Uh oh!

alvarezmelissa87 commented Nov 14, 2019

Uh oh!

elasticmachine commented Nov 14, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 14, 2019

💚 Build Succeeded

Uh oh!

lukeelmers left a comment

Choose a reason for hiding this comment

Uh oh!

lizozom commented Nov 15, 2019

Uh oh!

elasticmachine commented Nov 15, 2019

💚 Build Succeeded

Uh oh!

alexwizp commented Nov 15, 2019

Uh oh!

alvarezmelissa87 left a comment

Choose a reason for hiding this comment

Uh oh!

TinaHeiligers left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

alexwizp commented Nov 11, 2019 •

edited by lukeelmers

Loading

Relocated `@kbn/es-query` package to `data` plugin