-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Improve session idle timeout, add session lifespan #49855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jportner
merged 26 commits into
elastic:master
from
jportner:issue-18566-absolute-session-timeout
Nov 26, 2019
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d7cf8d4
Remove dead comment
jportner fa71ade
Add session lifespan, rename sessionTimeout to session.idleTimeout
jportner 00cf1d0
Add route config option to avoid extending the user's session timeout
jportner 86ea7c9
Change method of using Hapi RouteOptionsApp interface
jportner 45ee92d
Add /api/security/session/info endpoint
jportner b96b8da
Add /api/security/session/extend endpoint
jportner 59ead42
Revert "Change method of using Hapi RouteOptionsApp interface"
jportner 0a12ce6
Revert "Add route config option to avoid extending the user's session…
jportner 268111f
Remove "extendsSession" option from session info route
jportner e623b04
Revamp client-side session idle timeout
jportner 50fa1a0
Rename session timeout warning
jportner a12d33c
Add session lifespan warning
jportner 7e1ae0e
Create status_page plugin for New Platform
jportner 5f7c553
Update docs
jportner 3f989ca
Include provider name when calling logout endpoint
jportner 9e52cbd
Update session maxExpiration when server config changes
jportner 0a0bd39
Tweak BroadcastChannel behavior
jportner a8661f9
Merge branch 'master' of github.com:elastic/kibana into issue-18566-a…
jportner 62ba43b
Address review comments
jportner ab2b39c
Fix i18n test
jportner 3175a6f
Merge branch 'master' of github.com:elastic/kibana into issue-18566-a…
jportner c128fd5
Prevent flashing lifespan warning
jportner 6862001
Merge branch 'master' of github.com:elastic/kibana into issue-18566-a…
jportner 8b6d1fd
Address 2nd round of review comments
jportner 2649e5a
Fix basePath (tenant) issue
jportner 55d7f21
Merge branch 'master' of github.com:elastic/kibana into issue-18566-a…
jportner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "id": "status_page", | ||
| "version": "kibana", | ||
| "server": false, | ||
| "ui": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch B.V. licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import { PluginInitializer } from 'kibana/public'; | ||
| import { StatusPagePlugin, StatusPagePluginSetup, StatusPagePluginStart } from './plugin'; | ||
|
|
||
| export const plugin: PluginInitializer<StatusPagePluginSetup, StatusPagePluginStart> = () => | ||
| new StatusPagePlugin(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch B.V. licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import { Plugin, CoreSetup } from 'kibana/public'; | ||
|
|
||
| export class StatusPagePlugin implements Plugin<StatusPagePluginSetup, StatusPagePluginStart> { | ||
| public setup(core: CoreSetup) { | ||
| const isStatusPageAnonymous = core.injectedMetadata.getInjectedVar( | ||
| 'isStatusPageAnonymous' | ||
| ) as boolean; | ||
|
|
||
| if (isStatusPageAnonymous) { | ||
| core.http.anonymousPaths.register('/status'); | ||
| } | ||
| } | ||
|
|
||
| public start() {} | ||
|
|
||
| public stop() {} | ||
| } | ||
|
|
||
| export type StatusPagePluginSetup = ReturnType<StatusPagePlugin['setup']>; | ||
| export type StatusPagePluginStart = ReturnType<StatusPagePlugin['start']>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.