Skip to content

Ability to have telemetry always opted in #49798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 11, 2019
Merged

Ability to have telemetry always opted in #49798

merged 16 commits into from
Nov 11, 2019

Conversation

@mikecote
Copy link
Contributor

@mikecote mikecote commented Oct 30, 2019 •
edited
Loading

Resolves #49751

Two new kibana.yml properties are created, below is the combination matrix of the two new properties.

allowChangingOptInStatus: true allowChangingOptInStatus: false
optIn: null Default / current behaviour in Kibana Invalid
optIn: true Telemetry is opted in by default but the user can opt out. Telemetry is opted in and cannot be changed.
optIn: false Telemetry is oped out by default, the opt in banner doesn't show and the user can opt in via Advanced Settings. Invalid

@mikecote mikecote self-assigned this Oct 30, 2019
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 30, 2019

Pinging @elastic/kibana-stack-services (Team:Stack Services)

@mikecote mikecote force-pushed the telemetry/always-opted-in branch from 9ee6fe2 to e345799 Compare November 1, 2019 12:18
@pmuellr
Copy link
Member

pmuellr commented Nov 1, 2019

Looking good so far, server-side anyway ...

Bamieh
Bamieh reviewed Nov 4, 2019
View reviewed changes
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I do think @dimatkach point is worth considering for having allowChangingOptInStatus config reflected in a saved object and allow it to be modified via an endpoint that overrides the kibana.yml configs (#49751 (comment))

the optIn is already following a similar behavior (v2/optIn endpoint and the telemetry saved object)

@mikecote mikecote force-pushed the telemetry/always-opted-in branch from 55c387b to f7fa39d Compare November 6, 2019 03:29
@mikecote
Copy link
Contributor Author

mikecote commented Nov 6, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 6, 2019

💚 Build Succeeded

@mikecote mikecote marked this pull request as ready for review November 11, 2019 15:47
@mikecote mikecote requested a review from bmcconaghy November 11, 2019 15:47
@mikecote
Copy link
Contributor Author

mikecote commented Nov 11, 2019

@elasticmachine merge upstream

@mikecote
Copy link
Contributor Author

mikecote commented Nov 11, 2019

@Bamieh this will happen when allowChangingOptInStatus: false and optIn: null. It will read from the telemetry document and admins can change the value there.

bmcconaghy
bmcconaghy approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@mikecote
Copy link
Contributor Author

mikecote commented Nov 11, 2019

retest

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 11, 2019

💔 Build Failed

@mikecote
Copy link
Contributor Author

mikecote commented Nov 11, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 11, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 11, 2019

💔 Build Failed

Bamieh
Bamieh approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's remove if (allowChangingOptInStatus) { since allowChangingOptInStatus is going to be configurable via a saved object so we'd need that route to be there and check for allowChangingOptInStatus.

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 11, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 11, 2019

💚 Build Succeeded

@mikecote mikecote merged commit ea9bb0a into elastic:master Nov 11, 2019
mikecote added a commit to mikecote/kibana that referenced this pull request Nov 11, 2019
@mikecote
Ability to have telemetry always opted in (elastic#49798)
7ac8fa2 
* Initial work

* WIP changes

* Turn off banner when allowChangingOptInStatus is true

* Fix bugs

* Fix broken jest tests

* Add jest tests for TelemetryForm

* Add TelemetryOptIn jest tests

* Make some adjustments to allow always being opted in

* Disallow turning telemetry completely off

* Fix bug in Joi config

* Keep route there
@mikecote mikecote mentioned this pull request Nov 11, 2019
Merged
mikecote added a commit to mikecote/kibana that referenced this pull request Nov 11, 2019
@mikecote
Ability to have telemetry always opted in (elastic#49798)
92b6114 
* Initial work

* WIP changes

* Turn off banner when allowChangingOptInStatus is true

* Fix bugs

* Fix broken jest tests

* Add jest tests for TelemetryForm

* Add TelemetryOptIn jest tests

* Make some adjustments to allow always being opted in

* Disallow turning telemetry completely off

* Fix bug in Joi config

* Keep route there
@mikecote mikecote mentioned this pull request Nov 11, 2019
Merged
mikecote added a commit that referenced this pull request Nov 12, 2019
@mikecote
Ability to have telemetry always opted in (#49798) (#50236)
deebc34 
* Initial work

* WIP changes

* Turn off banner when allowChangingOptInStatus is true

* Fix bugs

* Fix broken jest tests

* Add jest tests for TelemetryForm

* Add TelemetryOptIn jest tests

* Make some adjustments to allow always being opted in

* Disallow turning telemetry completely off

* Fix bug in Joi config

* Keep route there
mikecote added a commit that referenced this pull request Nov 12, 2019
@mikecote
Ability to have telemetry always opted in (#49798) (#50235)
e2ff518 
* Initial work

* WIP changes

* Turn off banner when allowChangingOptInStatus is true

* Fix bugs

* Fix broken jest tests

* Add jest tests for TelemetryForm

* Add TelemetryOptIn jest tests

* Make some adjustments to allow always being opted in

* Disallow turning telemetry completely off

* Fix bug in Joi config

* Keep route there
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 12, 2019
@jloleysens
Merge remote-tracking branch 'upstream/master' into test-1
37d4836 
* upstream/master:
  [ML] Make navigation in tests more stable (elastic#50132)
  Migrate authorization subsystem to the new platform.  (elastic#46145)
  Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063)
  Update dependency @elastic/charts to v14 (elastic#49947)
  [ML] Adding cloud specific ML node warning (elastic#50139)
  Fixing bugs in the Shareable Runtime (elastic#49965)
  Revert router base name for Uptime plugin to use hash in default path. (elastic#50095)
  Ability to have telemetry always opted in (elastic#49798)
  Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797)
  Removes references to Elasticsearch mapping types (elastic#47610)
  [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167)
  [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147)
  [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 12, 2019
@jloleysens
Merge remote-tracking branch 'upstream/master' into test-3
7b512ad 
* upstream/master:
  Move table-list-view to kibana-react (elastic#50046)
  [ML] Stats bar for data frame analytics (elastic#49464)
  [ML] Make navigation in tests more stable (elastic#50132)
  Migrate authorization subsystem to the new platform.  (elastic#46145)
  Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063)
  Update dependency @elastic/charts to v14 (elastic#49947)
  [ML] Adding cloud specific ML node warning (elastic#50139)
  Fixing bugs in the Shareable Runtime (elastic#49965)
  Revert router base name for Uptime plugin to use hash in default path. (elastic#50095)
  Ability to have telemetry always opted in (elastic#49798)
  Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797)
  Removes references to Elasticsearch mapping types (elastic#47610)
  [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167)
  [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147)
  [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 12, 2019
@jloleysens
Merge remote-tracking branch 'upstream/master' into np-migration/ua […
faa2676 
…skip ci]

* upstream/master:
  Move table-list-view to kibana-react (elastic#50046)
  [ML] Stats bar for data frame analytics (elastic#49464)
  [ML] Make navigation in tests more stable (elastic#50132)
  Migrate authorization subsystem to the new platform.  (elastic#46145)
  Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063)
  Update dependency @elastic/charts to v14 (elastic#49947)
  [ML] Adding cloud specific ML node warning (elastic#50139)
  Fixing bugs in the Shareable Runtime (elastic#49965)
  Revert router base name for Uptime plugin to use hash in default path. (elastic#50095)
  Ability to have telemetry always opted in (elastic#49798)
  Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797)
  Removes references to Elasticsearch mapping types (elastic#47610)
  [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167)
  [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147)
  [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
@marius-dr marius-dr mentioned this pull request Nov 14, 2019
Closed
@alexfrancoeur alexfrancoeur mentioned this pull request Nov 15, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bamieh Bamieh Bamieh approved these changes

+1 more reviewer

@bmcconaghy bmcconaghy bmcconaghy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mikecote mikecote

Labels

Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v7.6.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

*yml* based setting to ship telemetry (and disable the UI to opt out)

5 participants

@mikecote @elasticmachine @pmuellr @bmcconaghy @Bamieh