-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Add labels to shell scripts in Jenkins #49657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brianseeders
merged 10 commits into
elastic:master
from
brianseeders:pipeline-sh-labels
Nov 15, 2019
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
859afd3
WIP adding labels to shell scripts in Jenkins
brianseeders 89f3cca
Missed parenthesis
brianseeders 1f28c8e
Add a couple of missing sh labels
brianseeders f63b83d
Add a couple more missing labels
brianseeders 63afa21
Fix syntax error
brianseeders 42e5e5e
Merge remote-tracking branch 'upstream/master' into pipeline-sh-labels
brianseeders db5f40b
Force labels for runbld/bash methods and add missing labels
brianseeders b371af6
Fix typo
brianseeders 1272cc9
Merge
brianseeders d4e4a4e
Merge branch 'master' into pipeline-sh-labels
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,17 @@ | ||
| def call(script, enableJunitProcessing = false) { | ||
| def call(script, label = "", enableJunitProcessing = false) { | ||
| def extraConfig = enableJunitProcessing ? "" : "--config ${env.WORKSPACE}/kibana/.ci/runbld_no_junit.yml" | ||
|
|
||
| sh "/usr/local/bin/runbld -d '${pwd()}' ${extraConfig} ${script}" | ||
| sh( | ||
| script: "/usr/local/bin/runbld -d '${pwd()}' ${extraConfig} ${script}", | ||
| label: label ?: script | ||
| ) | ||
| } | ||
|
|
||
| def junit() { | ||
| sh "/usr/local/bin/runbld -d '${pwd()}' ${env.WORKSPACE}/kibana/test/scripts/jenkins_runbld_junit.sh" | ||
| sh( | ||
| script: "/usr/local/bin/runbld -d '${pwd()}' ${env.WORKSPACE}/kibana/test/scripts/jenkins_runbld_junit.sh", | ||
| label: "Process JUnit reports with runbld" | ||
| ) | ||
| } | ||
|
|
||
| return this |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we could force definition of the label? Maybe same with runbld?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forced