Skip to content

Conversation

@streamich
Copy link
Contributor

Fixes App Architecture linter errors reported here.

@streamich streamich requested a review from a team as a code owner October 29, 2019 08:34
@streamich streamich requested review from lizozom and ppisljar October 29, 2019 08:34
@streamich streamich added release_note:skip Skip the PR/issue when compiling release notes review Team:AppArch v7.5.0 labels Oct 29, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich added v7.6.0 and removed v7.5.0 labels Oct 29, 2019
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when green

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@streamich streamich merged commit a10cf38 into elastic:master Oct 30, 2019
streamich added a commit that referenced this pull request Oct 30, 2019
* fix: 🐛 fix unused persistedLog object

* chore: 🤖 ignore ESLint rule

* fix: 🐛 correct dependencies in useUnmount() hook

* fix: 🐛 fix ESLint errors

* chore: 🤖 disable ESLint rule

* fix: 🐛 add savedQueryService to dependency list

* fix: 🐛 fix ESLint errors in data plugin

* chore: 🤖 fix self-closing ESLint rule

* test: 💍 update Jest snapshot

* refactor: 💡 memoize persistedLog in more idiomatic way

* chore: 🤖 remomve unused import

* chore: 🤖 revert possible test breaker

* fix: 🐛 fix query bar merge errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes review v7.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants