Conversation
spalger
added
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
💔 Build Failed |
tylersmalley
approved these changes
Oct 22, 2019
Member
|
Looks like |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
added 3 commits
October 23, 2019 16:59
# Conflicts: # packages/kbn-pm/dist/index.js
This comment has been minimized.
This comment has been minimized.
added 2 commits
October 23, 2019 21:22
# Conflicts: # packages/kbn-es/package.json # packages/kbn-plugin-helpers/package.json # packages/kbn-pm/dist/index.js # packages/kbn-pm/package.json
Contributor
💔 Build Failed |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Oct 24, 2019
* Update dependency del to v5 * unify del/rimraf usage with del v5 * update yarn.lock * update kbn-pm distributable * remove poorly transformed code * force some deletes from tmp * mock less of the fs module * force tmp deletion in a few more suites * please make this the last force # Conflicts: # packages/kbn-plugin-helpers/package.json
spalger
pushed a commit
that referenced
this pull request
Oct 24, 2019
* Update dependency del to v5 * unify del/rimraf usage with del v5 * update yarn.lock * update kbn-pm distributable * remove poorly transformed code * force some deletes from tmp * mock less of the fs module * force tmp deletion in a few more suites * please make this the last force # Conflicts: # packages/kbn-plugin-helpers/package.json
Contributor
Author
|
7.x/7.6: 4bd85e3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use both rimraf and del, which do the same thing, but
delsupports TS and promises natively, as also have protections against deletes outside of the CWD which is a great backup for arbitrary file deletes we're doing in different places.