[SIEM] Additional Endgame Row Renderer Code Coverage#48722
Merged
andrew-goldstein merged 2 commits intoelastic:masterfrom Oct 22, 2019
Merged
Conversation
Adds additional unit test coverage for the [Endgame row renderers](elastic#48277) ### Endgame Event Types / Subtypes Additional unit tests were added for the following Endgame event types / subtypes: * DNS (`dns_event`) - [X] `request_event` * File (FIM) (`file_event`) - [X] `file_create_event` - [X] `file_delete_event` * Network (`network_event`) - [X] `ipv4_connection_accept_event` - [X] `ipv6_connection_accept_event` - [X] `ipv4_disconnect_received_event` - [X] `ipv6_disconnect_received_event` * Security (Authentication) (`security_event`) - [X] `user_logon` - [X] `admin_logon` - [X] `explicit_user_logon` - [X] `user_logoff` * Process (`process_event`) - [X] `creation_event` - [X] `termination_event` ### Non-Endgame Events Additional unit tests for some non-Endgame events were also added, including: * FIM file `created` events * FIM file `deleted` events * Socket `socket_opened` events * Socket `socket_closed` events elastic/ecs-dev#178
andrew-goldstein
added
Team:SIEM
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
Contributor
💚 Build Succeeded |
stephmilovic
approved these changes
Oct 21, 2019
Contributor
stephmilovic
left a comment
stephmilovic
left a comment
There was a problem hiding this comment.
More code coverage is always greatly appreciated... way to cover your tracks ;)
LGTM!
Contributor
Author
|
@elasticmachine update branch |
Contributor
💚 Build Succeeded |
This was referenced Oct 22, 2019
andrew-goldstein
added a commit
to andrew-goldstein/kibana
that referenced
this pull request
Oct 22, 2019
## [SIEM] Additional Endgame Row Renderer Code Coverage Adds additional unit test coverage for the [Endgame row renderers](elastic#48277) ### Endgame Event Types / Subtypes Additional unit tests were added for the following Endgame event types / subtypes: * DNS (`dns_event`) - [X] `request_event` * File (FIM) (`file_event`) - [X] `file_create_event` - [X] `file_delete_event` * Network (`network_event`) - [X] `ipv4_connection_accept_event` - [X] `ipv6_connection_accept_event` - [X] `ipv4_disconnect_received_event` - [X] `ipv6_disconnect_received_event` * Security (Authentication) (`security_event`) - [X] `user_logon` - [X] `admin_logon` - [X] `explicit_user_logon` - [X] `user_logoff` * Process (`process_event`) - [X] `creation_event` - [X] `termination_event` ### Non-Endgame Events Additional unit tests for some non-Endgame events were also added, including: * FIM file `created` events * FIM file `deleted` events * Socket `socket_opened` events * Socket `socket_closed` events elastic/ecs-dev#178
andrew-goldstein
added a commit
that referenced
this pull request
Oct 22, 2019
## [SIEM] Additional Endgame Row Renderer Code Coverage Adds additional unit test coverage for the [Endgame row renderers](#48277) ### Endgame Event Types / Subtypes Additional unit tests were added for the following Endgame event types / subtypes: * DNS (`dns_event`) - [X] `request_event` * File (FIM) (`file_event`) - [X] `file_create_event` - [X] `file_delete_event` * Network (`network_event`) - [X] `ipv4_connection_accept_event` - [X] `ipv6_connection_accept_event` - [X] `ipv4_disconnect_received_event` - [X] `ipv6_disconnect_received_event` * Security (Authentication) (`security_event`) - [X] `user_logon` - [X] `admin_logon` - [X] `explicit_user_logon` - [X] `user_logoff` * Process (`process_event`) - [X] `creation_event` - [X] `termination_event` ### Non-Endgame Events Additional unit tests for some non-Endgame events were also added, including: * FIM file `created` events * FIM file `deleted` events * Socket `socket_opened` events * Socket `socket_closed` events elastic/ecs-dev#178
andrew-goldstein
added a commit
that referenced
this pull request
Oct 22, 2019
## [SIEM] Additional Endgame Row Renderer Code Coverage Adds additional unit test coverage for the [Endgame row renderers](#48277) ### Endgame Event Types / Subtypes Additional unit tests were added for the following Endgame event types / subtypes: * DNS (`dns_event`) - [X] `request_event` * File (FIM) (`file_event`) - [X] `file_create_event` - [X] `file_delete_event` * Network (`network_event`) - [X] `ipv4_connection_accept_event` - [X] `ipv6_connection_accept_event` - [X] `ipv4_disconnect_received_event` - [X] `ipv6_disconnect_received_event` * Security (Authentication) (`security_event`) - [X] `user_logon` - [X] `admin_logon` - [X] `explicit_user_logon` - [X] `user_logoff` * Process (`process_event`) - [X] `creation_event` - [X] `termination_event` ### Non-Endgame Events Additional unit tests for some non-Endgame events were also added, including: * FIM file `created` events * FIM file `deleted` events * Socket `socket_opened` events * Socket `socket_closed` events elastic/ecs-dev#178
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[SIEM] Additional Endgame Row Renderer Code Coverage
Adds additional unit test coverage for the Endgame row renderers
Endgame Event Types / Subtypes
Additional unit tests were added for the following Endgame event types / subtypes:
dns_event)request_eventfile_event)file_create_eventfile_delete_eventnetwork_event)ipv4_connection_accept_eventipv6_connection_accept_eventipv4_disconnect_received_eventipv6_disconnect_received_eventsecurity_event)user_logonadmin_logonexplicit_user_logonuser_logoffprocess_event)creation_eventtermination_eventNon-Endgame Events
Additional unit tests for some non-Endgame events were also added, including:
createdeventsdeletedeventssocket_openedeventssocket_closedeventshttps://github.com/elastic/ecs-dev/issues/178